Using media type to determine correct param type when expanding param… #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2404 +/- ##
============================================
+ Coverage 95.41% 95.42% +<.01%
- Complexity 2956 2960 +4
============================================
Files 336 336
Lines 7856 7863 +7
Branches 620 621 +1
============================================
+ Hits 7496 7503 +7
Misses 227 227
Partials 133 133 |
|
Thanks @andyRokit for the PR! 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
This PR attempts to resolve #2376 by using the media type to determine the parameter type when expanding.
Are there unit tests? If not how should this be manually tested?
The intentional change was made to
OperationParameterReaderSpec.groovy. I split the "Should expand ModelAttribute request params" test into two. One for multipart, one for non-multipart. I aimed to keep any other test changes to a minimum.Any background context you want to provide?
N/a
What are the relevant issues?
#2376