Skip to content

Angular: Filter non-inputs from controls #30550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

robertIsaac
Copy link
Contributor

@robertIsaac robertIsaac commented Feb 15, 2025

Relates #16865

rebase #18880 on next branch

Greptile Summary

Adds a feature flag to filter non-input controls from Angular components in Storybook, providing a cleaner and more focused controls panel by showing only input properties.

  • Modified code/frameworks/angular/src/client/docs/compodoc.ts to add FEATURES.angularFilterNonInputControls flag
  • Updated extractArgTypesFromData to only include inputsClass when feature flag is enabled
  • Excluded propertiesClass, methodsClass, and outputsClass with active feature flag
  • Maintains backward compatibility by preserving full property extraction when flag is disabled

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@robertIsaac
Copy link
Contributor Author

hi @valentinpalkovic
do you plan to merge this soon?

@valentinpalkovic
Copy link
Contributor

Hi @robertIsaac,

I am currently on vacation but I will take a look in roughly two weeks!

@Frozen-byte
Copy link

Frozen-byte commented May 6, 2025

@valentinpalkovic friendly reminder for this MR; we are waiting for the merge, too.

Copy link

nx-cloud bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit cdb98e8.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 46s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 20:37:29 UTC

@valentinpalkovic valentinpalkovic merged commit bc89e14 into storybookjs:next May 6, 2025
59 checks passed
@github-actions github-actions bot mentioned this pull request May 6, 2025
22 tasks
@robertIsaac robertIsaac deleted the 16865-angular-filter-non-input-controls branch May 6, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy