React: Remove react import in template files #30757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
20 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -1,5 +1,3 @@ | |||
| import React from 'react'; | |||
|
|
|||
| import './button.css'; | |||
There was a problem hiding this comment.
logic: React import needed for JSX syntax - either keep the React import or use a JSX runtime import
Suggested change
| import './button.css'; | |
| import React from 'react'; | |
| import './button.css'; |
Comment on lines
1
to
4
| import { Header } from './Header'; | ||
| import './page.css'; |
There was a problem hiding this comment.
style: Either React import needs to be restored, or useState should be imported directly from 'react' like: import { useState } from 'react'
Suggested change
| import { Header } from './Header'; | |
| import './page.css'; | |
| import { Header } from './Header'; | |
| import { useState } from 'react'; | |
| import './page.css'; |
|
View your CI Pipeline Execution ↗ for commit a5537ec.
☁️ Nx Cloud last updated this comment at |
ad0b326 to
4e7a056
Compare
This was referenced Mar 14, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR removes React imports from template files across Next.js and React renderer templates, aligning with modern React 17+ practices but introducing potential compatibility concerns.
Page.jsx/tsxfiles still useReact.useStatewithout React in scope, which will cause runtime errorstsconfig.jsonto change jsx option from 'react' to 'preserve', requiring verification with build tools.eslintrc.jsReact.FCand other React types need proper type imports