Core: Fix favicon issue on dev server #30818
Conversation
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Hey @kasperpeulen, could you please review this PR? It's been a month since i have issued this PR. Thanks. |
|
View your CI Pipeline Execution ↗ for commit ac836df.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| const faviconFile = basename(faviconPath); | ||
| app.use('/', (req, res, next) => { | ||
| if (req.url === `/${faviconFile}`) { | ||
| return sirvWorkaround(faviconDir, { |
There was a problem hiding this comment.
style: Consider checking if faviconPath exists before attempting to serve it, similar to the check on line 28 for static files
| return sirvWorkaround(faviconDir, { | |
| if (!existsSync(faviconPath)) { | |
| logger.warn(`Favicon file not found at ${faviconPath}`); | |
| return next(); | |
| } | |
| return sirvWorkaround(faviconDir, { |
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Closes #30158
What I did
Fixed an issue where the favicon was not loading correctly in development mode. The fix ensures the favicon is served from its directory instead of attempting to serve the file directly.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Here’s a screenshot showing the favicon working correctly after the fix:
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR fixes an issue where the favicon wasn't loading correctly in Storybook's development server.
useStaticsfunction to properly handle favicon serving in development modesirvWorkaroundto handle middleware conflictsGreptile AI
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!