Core: New Test Provider Store #30828
Conversation
|
View your CI Pipeline Execution ↗ for commit d1230da.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 70 | 70 | 0 |
| Self size | 24.32 MB | 24.36 MB | 🚨 +31 KB 🚨 |
| Dependency size | 23.96 MB | 23.96 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 71 | 71 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 48.29 MB | 48.32 MB | 🚨 +31 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 363 | 363 | 0 |
| Self size | 289 KB | 289 KB | 0 B |
| Dependency size | 98.30 MB | 98.33 MB | 🚨 +31 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 284 | 284 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 80.09 MB | 80.12 MB | 🚨 +31 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
…st-provider-store
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new test provider store to support an upcoming migration away from the existing test provider APIs. The changes include implementation of the test provider store in both core-server and manager-api modules, type tests for the new store, and corresponding mocks and global exports updates.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| code/core/src/core-server/stores/test-provider.ts | Implements the new test provider store with a temporary workaround for vitest. |
| code/core/src/shared/test-provider-store/index.test-d.ts | Adds type tests for the test provider store APIs. |
| code/core/src/manager-api/stores/test-provider.ts | Provides the new test provider store for manager-api with production flag logic. |
| code/core/src/manager-api/stores/mocks/test-provider.ts | Implements a mock version of the test provider store for testing purposes. |
| code/core/src/manager-api/root.tsx | Re-exports the new test provider store functions as experimental APIs. |
| code/core/src/core-server/index.ts | Re-exports the new test provider store functions for core server usage. |
| code/core/src/manager/globals/exports.ts | Updates the globals exports to include the new test provider store APIs. |
There was a problem hiding this comment.
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Works on #30746
What I did
Added a new test provider store, similar to the new status store - without actually using it anywhere.
In follow-up PRs we'll use this new store in the manager UI, update addon-test and VTA to use it, before finally removing the existing test provider APIs.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Implemented a new test provider store with universal store integration to support upcoming migration from existing test provider APIs.
code/core/src/shared/test-provider-store/index.tsimplementing core store functionality with comprehensive type safety and testingcode/core/src/manager-api/stores/test-provider.tswith production-mode leader configurationcode/core/src/core-server/stores/test-provider.tsto prevent store creation in vitest sub-processescode/core/src/shared/test-provider-store/index.test-d.tsverifying store API type safety