React-Native: Fix userEvent.setup() errors outside browser context
#30831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser context (react native)
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+80
to
82
| if (globalThis.window && globalThis.HTMLElement) { | ||
| context.userEvent = instrument({ userEvent: userEvent.setup() }, { intercept: true }).userEvent; | ||
| } |
There was a problem hiding this comment.
style: Consider adding a fallback behavior or warning message when userEvent cannot be initialized in non-browser environments
|
View your CI Pipeline Execution ↗ for commit 94c10a1.
☁️ Nx Cloud last updated this comment at |
userEvent.setup() errors outside browser context
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
protect against calling userEvent setup when not in a supported context like react native
fixes the error causing the latest alpha to fail on react native
The error comes from testing library using window.navigator.clipboard and other browser specific things
Checklist for Contributors
Testing
tested by editing in node modules on my alpha 6 branch
storybookjs/react-native#699
I add the check in
node_modules/storybook/dist/test/preview.js
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30831-sha-94c10a14. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30831-sha-94c10a14 sandboxor in an existing project withnpx storybook@0.0.0-pr-30831-sha-94c10a14 upgrade.More information
0.0.0-pr-30831-sha-94c10a14dannyhw/fix-userevent-not-callable-in-reactnative94c10a141742227989)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30831