Controls: Embed addon-controls into the core #30864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, migrating its functionality into core. Update dependencies and documentation accordingly.
…core. Added detailed comments regarding the future of inferControls and the need for a decision on addon integration.
|
View your CI Pipeline Execution ↗ for commit 8cd7367.
☁️ Nx Cloud last updated this comment at |
… script definitions for controls in entries.ts. Add '@storybook/addon-controls' to consolidated packages for better integration.
…torybookjs/storybook into norbert/addon-controls-in-core
… core and adjust formatting for consistency.
…d comment out reenable tasks for bench-packages and bench-sandboxes in workflows.
There was a problem hiding this comment.
55 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| PureArgsTable as ArgsTable, | ||
| type PresetColor, | ||
| type SortType, | ||
| } from '../../../../lib/blocks/src/index'; |
There was a problem hiding this comment.
style: Relative import path may be fragile. Consider using an alias or absolute import path.
…ols and Addon Actions to core, and adjust related sections for consistency and clarity.
valentinpalkovic
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This pull request includes several significant changes to the Storybook project, primarily focusing on the removal of the
@storybook/addon-controlsaddon and its associated files and references. The changes also involve updates to related documentation and configuration files.Removal of
@storybook/addon-controls:code/.storybook/main.ts: Removed thecontrolsaddon directory and titlePrefix references.code/addons/controls/README.md: Deleted the entire README file for thecontrolsaddon.code/addons/controls/manager.js: Removed the import statement for thecontrolsmanager.code/addons/controls/package.json: Deleted thepackage.jsonfile for thecontrolsaddon.code/addons/controls/project.json: Deleted theproject.jsonfile for thecontrolsaddon.code/addons/controls/src/index.ts: Removed all exports and imports related to thecontrolsaddon.code/addons/controls/tsconfig.json: Deleted thetsconfig.jsonfile for thecontrolsaddon.code/addons/controls/vitest.config.ts: Deleted thevitest.config.tsfile for thecontrolsaddon.Updates to related documentation and configuration files:
code/addons/essentials/README.md: Removed references to thecontrolsaddon from the essentials README. [1] [2]code/addons/essentials/package.json: Removedcontrolsaddon dependencies and manager entries. [1] [2] [3]code/addons/essentials/src/controls/manager.ts: Removed the export statement for thecontrolsmanager.code/addons/essentials/src/preset.ts: Removed thecontrolsoption from the preset options and updated the addons list. [1] [2]Adjustments to onboarding addon:
code/addons/onboarding/src/Onboarding.tsx: Updated thesetSelectedPanelcall to use theCONTROLS_ADDON_IDconstant. [1] [2]code/addons/onboarding/src/manager.tsx: Updated thesetSelectedPanelcall to use theCONTROLS_ADDON_IDconstant. [1] [2]Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR embeds the controls addon functionality directly into Storybook core, removing the standalone @storybook/addon-controls package while maintaining all existing functionality.
code/addons/controls/and updated all test storybooks to remove the addon dependencycode/core/src/controls/with updated import paths and internal structurecode/core/scripts/entries.tsto include new core entries for controls functionality