-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Addons: Move @storybook/addon-interactions into core #30916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d095390
to
6c3ec54
Compare
View your CI Pipeline Execution ↗ for commit 5911cae.
☁️ Nx Cloud last updated this comment at |
6c3ec54
to
19e48fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
168 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
ndelangen
reviewed
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
This PR implements a significant architectural change in Storybook's testing infrastructure by consolidating the interactions testing functionality from the standalone @storybook/addon-interactions into the core component testing module. This change aims to streamline the testing experience and reduce fragmentation in the codebase.
Key Changes
1. Addon Consolidation
2. Component Migration
The following components were moved from addons/interactions to core/component-testing:
3. Configuration Updates
@storybook/addon-interactions
dependencies4. Dependencies Removed from @storybook/addon-test
Notes
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30916-sha-e160c7e2
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30916-sha-e160c7e2 sandbox
or in an existing project withnpx storybook@0.0.0-pr-30916-sha-e160c7e2 upgrade
.More information
0.0.0-pr-30916-sha-e160c7e2
valentin/remove-addon-interactions-2
e160c7e2
1742907231
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30916
Greptile Summary
Here's a concise summary of this significant architectural change to Storybook's testing infrastructure:
This PR consolidates the interactions testing functionality from @storybook/addon-interactions into the core component testing module, streamlining Storybook's testing infrastructure.
Key changes:
The changes appear well-structured and maintain existing functionality while reducing codebase fragmentation. However, careful testing is needed to ensure all interaction testing capabilities work properly after consolidation.