Skip to content

Core: Prebundle jsdoc-type-pratt-parser again #30923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 25, 2025

Closes #29130

What I did

We stopped prebundling jsdoc-type-pratt-parser because of a React native issue:
#29130

I re-enabled the bundling of this package, by not transpiling unicode escape characters.

Regex unicode escape character is an ES2018 feature, but esbuild is really strict here.
Since not all browser support the latest Unicode characters.
This feature also only works in older browsers in combination with a Regex polyfill that we don't load.

The Hermes engine of React Native doesn't support this feature,
but leaving the regex alone, actually allows Hermes to do its own thing,
without us having to load a RegExp polyfill.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates esbuild configuration to prevent unicode regex transpilation and moves jsdoc-type-pratt-parser to devDependencies in the core package.

  • Modified code/core/scripts/prep.ts to enable 'regexp-unicode-property-escapes' support in esbuild, avoiding RegExp polyfill loading
  • Moved 'jsdoc-type-pratt-parser' to devDependencies in code/core/package.json as it's only needed during build time
  • Change improves React Native (Hermes engine) compatibility by allowing native handling of unicode regex patterns

@kasperpeulen kasperpeulen changed the title Core: Don't transpile unicode regex in core bundler Core: Prebundle jsdoc-type-pratt-parser again Mar 25, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Mar 25, 2025

View your CI Pipeline Execution ↗ for commit 37c1653.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 55s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-25 14:09:41 UTC

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAHOO!!! Great stuff @kasperpeulen

@shilman shilman added the core label Mar 25, 2025
@kasperpeulen kasperpeulen self-assigned this Mar 25, 2025
@kasperpeulen kasperpeulen merged commit 5501e70 into next Mar 25, 2025
44 of 54 checks passed
@kasperpeulen kasperpeulen deleted the kasper/unicode-esbuild branch March 25, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: storybook 8 react native error on regex from jsdoc-type-pratt-parser
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy