-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Maintenance: Drop tooling support #30940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
….json files and update block-node-version autoblocker
… require Angular 18 and above
…te package dependencies to require Vite 5.0.0 and up across all packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes legacy tooling support by dropping compatibility with older Angular versions and older Vite versions, and updating package manager requirements.
- Removed support for legacy Angular options and build configurations.
- Updated Vite configuration property names to align with current Vite version requirements.
- Enhanced migration documentation with new package manager and framework-specific changes.
Reviewed Changes
Copilot reviewed 29 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
code/frameworks/angular/src/types.ts | Removed the deprecated "enableNgcc" property from AngularOptions. |
code/frameworks/angular/src/server/framework-preset-angular-ivy.ts | Removed ngcc-related logic and extra mainFields options for older Angular versions. |
code/frameworks/angular/src/server/angular-cli-webpack.js | Removed older Angular webpack configs, now focusing on configurations for Angular 16.1+. |
code/builders/builder-vite/src/vite-config.ts | Updated the Vite config environment property from "ssrBuild" to "isSsrBuild". |
MIGRATION.md | Added migration notes for dropped support for Vite 4 and Angular versions below 18, and updated package manager support. |
Files not reviewed (15)
- code/addons/docs/package.json: Language not supported
- code/builders/builder-vite/package.json: Language not supported
- code/frameworks/angular/package.json: Language not supported
- code/frameworks/ember/package.json: Language not supported
- code/frameworks/experimental-nextjs-vite/package.json: Language not supported
- code/frameworks/html-vite/package.json: Language not supported
- code/frameworks/html-webpack5/package.json: Language not supported
- code/frameworks/nextjs/package.json: Language not supported
- code/frameworks/preact-vite/package.json: Language not supported
- code/frameworks/preact-webpack5/package.json: Language not supported
- code/frameworks/react-native-web-vite/package.json: Language not supported
- code/frameworks/react-vite/package.json: Language not supported
- code/frameworks/react-webpack5/package.json: Language not supported
- code/frameworks/server-webpack5/package.json: Language not supported
- code/frameworks/svelte-vite/package.json: Language not supported
View your CI Pipeline Execution ↗ for commit 8c556d6.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
117 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
…son and yarn.lock files
…anges in documentation and dependency requirements. Adjusted compatibility comments and removed legacy code for earlier Next.js versions.
…ngular version based on project dependencies. Removed unnecessary extraDependencies from sandbox templates.
…and update package dependencies to require Vite 5.0.0 and up across all packages" This reverts commit 9c64c48.
…te package dependencies to require Vite 5.0.0 and up across all packages
I think you may have missed a node version reference in the bin files: storybook/code/core/bin/index.cjs Lines 3 to 7 in 447caec
|
…gn with recent dependency requirements.
…ag for improved readability.
…torybook compatibility.
Closes #30353
What I did
This PR drops support for older tooling versions across Storybook packages:
Migration guide entries have been added to document these changes.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR implements major breaking changes for Storybook 9.0, dropping support for older tooling versions and updating minimum requirements across the ecosystem.
autodocs
config,globals
in favor ofinitialGlobals
, and legacy button propsThe changes are well documented in MIGRATION.md with clear upgrade paths provided.