Skip to content

Maintenance: Drop tooling support #30940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 28, 2025
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Mar 27, 2025

Closes #30353

What I did

This PR drops support for older tooling versions across Storybook packages:

  • Drops Vite 4 support, requiring Vite 5+ across all Vite-based frameworks and builders
  • Drops Angular <18 support
  • Drops Node.js <20 support
  • Drops Next.js <14.1.0 support
  • Updates package manager requirements (npm v10+, yarn v4+, pnpm v9+)

Migration guide entries have been added to document these changes.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR implements major breaking changes for Storybook 9.0, dropping support for older tooling versions and updating minimum requirements across the ecosystem.

  • Raises minimum Node.js requirement to v20+ across all packages, dropping v18 support
  • Removes Vite 4 support, requiring Vite 5+ for all Vite-based frameworks and builders
  • Drops Angular <18 support and updates related dependencies
  • Removes several deprecated APIs including autodocs config, globals in favor of initialGlobals, and legacy button props
  • Updates package manager requirements to npm v10+, yarn v4+, and pnpm v9+

The changes are well documented in MIGRATION.md with clear upgrade paths provided.

@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/api-removals March 27, 2025 09:36
@valentinpalkovic valentinpalkovic self-assigned this Mar 27, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes legacy tooling support by dropping compatibility with older Angular versions and older Vite versions, and updating package manager requirements.

  • Removed support for legacy Angular options and build configurations.
  • Updated Vite configuration property names to align with current Vite version requirements.
  • Enhanced migration documentation with new package manager and framework-specific changes.

Reviewed Changes

Copilot reviewed 29 out of 44 changed files in this pull request and generated no comments.

Show a summary per file
File Description
code/frameworks/angular/src/types.ts Removed the deprecated "enableNgcc" property from AngularOptions.
code/frameworks/angular/src/server/framework-preset-angular-ivy.ts Removed ngcc-related logic and extra mainFields options for older Angular versions.
code/frameworks/angular/src/server/angular-cli-webpack.js Removed older Angular webpack configs, now focusing on configurations for Angular 16.1+.
code/builders/builder-vite/src/vite-config.ts Updated the Vite config environment property from "ssrBuild" to "isSsrBuild".
MIGRATION.md Added migration notes for dropped support for Vite 4 and Angular versions below 18, and updated package manager support.
Files not reviewed (15)
  • code/addons/docs/package.json: Language not supported
  • code/builders/builder-vite/package.json: Language not supported
  • code/frameworks/angular/package.json: Language not supported
  • code/frameworks/ember/package.json: Language not supported
  • code/frameworks/experimental-nextjs-vite/package.json: Language not supported
  • code/frameworks/html-vite/package.json: Language not supported
  • code/frameworks/html-webpack5/package.json: Language not supported
  • code/frameworks/nextjs/package.json: Language not supported
  • code/frameworks/preact-vite/package.json: Language not supported
  • code/frameworks/preact-webpack5/package.json: Language not supported
  • code/frameworks/react-native-web-vite/package.json: Language not supported
  • code/frameworks/react-vite/package.json: Language not supported
  • code/frameworks/react-webpack5/package.json: Language not supported
  • code/frameworks/server-webpack5/package.json: Language not supported
  • code/frameworks/svelte-vite/package.json: Language not supported

@valentinpalkovic valentinpalkovic added BREAKING CHANGE ci:daily Run the CI jobs that normally run in the daily job. labels Mar 27, 2025
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 8c556d6

Copy link

nx-cloud bot commented Mar 27, 2025

View your CI Pipeline Execution ↗ for commit 8c556d6.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 52s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-28 13:11:58 UTC

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

117 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic valentinpalkovic added ci:merged Run the CI jobs that normally run when merged. and removed ci:daily Run the CI jobs that normally run in the daily job. labels Mar 27, 2025
…ngular version based on project dependencies. Removed unnecessary extraDependencies from sandbox templates.
…and update package dependencies to require Vite 5.0.0 and up across all packages"

This reverts commit 9c64c48.
…te package dependencies to require Vite 5.0.0 and up across all packages
@valentinpalkovic valentinpalkovic added ci:normal and removed ci:merged Run the CI jobs that normally run when merged. labels Mar 27, 2025
@ndelangen
Copy link
Member

I think you may have missed a node version reference in the bin files:

const majorNodeVersion = parseInt(process.versions.node, 10);
if (majorNodeVersion < 18) {
console.error('To run Storybook you need to have Node.js 18 or higher');
process.exit(1);
}

Base automatically changed from valentin/api-removals to next March 28, 2025 11:28
@valentinpalkovic valentinpalkovic merged commit c001e4b into next Mar 28, 2025
33 of 34 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/drop-tooling-support branch March 28, 2025 15:15
@github-actions github-actions bot mentioned this pull request Mar 28, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storybook 9]: Drop support for tooling/integrations/frameworks
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy