Core: Remove deprecated parts of test provider API #30962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit f4af0af.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
LGTM
18 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
yannbf
reviewed
Mar 28, 2025
| return ( | ||
| <TestProvider key={state.id} data-module-id={state.id}> | ||
| {Render ? <Render {...state} /> : <LegacyRender {...state} />} | ||
| <TestProvider key={id} data-module-id={id}> |
There was a problem hiding this comment.
Do we need to add an error boundary here? I'm wondering whether an addon can break the entire testing module if it has some buggy code there
There was a problem hiding this comment.
so I introduced some slight defence by ensuring that we only render if there actually is a render method.
But having an error boundaries should be a single pattern that we introduce across all the places where we render addons, I don't want to introduce that in this PR.
yannbf
approved these changes
Mar 28, 2025
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30746
Depends on chromaui/addon-visual-tests#367
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR fully removes deprecated test provider API parts and legacy UI components to align with the new test provider architecture.
• Removed the entire experimental API in /code/core/src/manager-api/modules/experimental_testmodule.ts and its dependent state references in /code/core/src/manager-api/root.tsx.
• Cleared deprecated test events from /code/core/src/core-events/index.ts and global exports in /code/core/src/manager/globals/exports.ts.
• Eliminated legacy UI components like LegacyRender from /code/core/src/manager/components/sidebar/LegacyRender.tsx and updated related stories in TestingModule.stories.tsx and SidebarBottom.stories.tsx.
• Adjusted addon registration in /code/addons/test/src/manager.tsx and updated type usage in /code/core/src/types/modules/addons.ts.
• Updated event listeners and test provider store calls in Sidebar and Tree stories to reference the new API via useStorybookApi().