Skip to content

Interactions: Rename component test panel #31130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Apr 15, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR renames the "Component test" panel to "Interactions" across the Storybook UI, ensuring consistent terminology for interaction testing functionality.

  • Changed addon ID from storybook/component-tests to storybook/interactions in code/core/src/component-testing/constants.ts
  • Updated panel title from "Component tests" to "Interactions" in code/core/src/component-testing/components/PanelTitle.tsx
  • Modified DOM element selectors in e2e tests to use #tabbutton-storybook-interactions-panel instead of #tabbutton-storybook-component-tests-panel
  • Added new constant DOCUMENTATION_PLAY_FUNCTION_LINK for documentation about writing stories with play function
  • Note: Inconsistency in preview-api.spec.ts where panel is still referred to as "Component test" in one location

@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks ci:normal labels Apr 15, 2025
@valentinpalkovic valentinpalkovic self-assigned this Apr 15, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Apr 15, 2025

View your CI Pipeline Execution ↗ for commit a470a32.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 36s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-15 13:50:03 UTC

@valentinpalkovic valentinpalkovic force-pushed the valentin/rename-component-test-panel-to-interactions branch from c8a952d to a470a32 Compare April 15, 2025 13:45
@shilman shilman merged commit c999b31 into next Apr 15, 2025
56 checks passed
@shilman shilman deleted the valentin/rename-component-test-panel-to-interactions branch April 15, 2025 21:07
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy