Init: Install framework stories instead of renderer stories #31160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit e0ed630.
☁️ Nx Cloud last updated this comment at |
503ce4a to
5601dd8
Compare
Update framework template support in baseGenerator Add template stories for react-webpack5 Move renderer templates into frameworks Add support for additional frameworks in baseGenerator Refactor baseGenerator to improve framework handling and package installation logic Fix imports Readd templates to renderers
5601dd8 to
891ad90
Compare
48d31fc to
b9c6eb4
Compare
…-renderer-package
ndelangen
approved these changes
Apr 22, 2025
ndelangen
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
When initializing Storybook in an empty directory, the bootstrapped stories contained
@storybook/reactreferences instead of@storybook/react-vite.I have:
ts-4-9totsand renamed supported languageTYPESCRIPT_4_9toTYPESCRIPTChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31160-sha-1cdd9ea9. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-31160-sha-1cdd9ea9 sandboxor in an existing project withnpx storybook@0.0.0-pr-31160-sha-1cdd9ea9 upgrade.More information
0.0.0-pr-31160-sha-1cdd9ea9valentin/dont-install-renderer-package1cdd9ea91745309749)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31160Greptile Summary
Simplified Storybook initialization by removing automatic renderer package installation during setup, streamlining the framework configuration process.
code/lib/create-storybook/src/generators/baseGenerator.tsto exclude rendererPackage from the packages array in getFrameworkDetails functionNote: This is a significant architectural change that affects how Storybook handles framework initialization, though the implementation is straightforward.