Skip to content

Svelte: Fix missing ts-dedent dependency #31289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 29, 2025
Merged

Svelte: Fix missing ts-dedent dependency #31289

merged 6 commits into from
Apr 29, 2025

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Apr 29, 2025 •
edited by greptile-apps bot
Loading

Follow-up to #31227, reaction to #31227 (comment)

What I did

Added ts-dedent back to the Svelte renderer because it was removed by mistake. Also made some small changes that should hopefully make Knip detect this better in the future.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Restores the ts-dedent dependency to the Svelte renderer and improves dependency management configuration after it was accidentally removed in a previous cleanup.

  • Added ts-dedent v2.0.0 as a dependency in code/renderers/svelte/package.json
  • Added outDir configuration in code/renderers/svelte/tsconfig.json to improve Knip dependency analysis
  • Removed webpack-env type reference from code/renderers/svelte/src/index.ts

@JReinhold JReinhold self-assigned this Apr 29, 2025
@JReinhold JReinhold requested a review from ndelangen April 29, 2025 07:27
greptile-apps[bot]
greptile-apps bot reviewed Apr 29, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b2d11d9.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-29 10:24:09 UTC

@webpro
Copy link
Contributor

webpro commented Apr 29, 2025

Thanks! We also need to update Knip itself (to at least v5.51.0) to have source mapping supported for compiled extensions (.svelte in this case).

@JReinhold
Copy link
Contributor Author

Thanks! We also need to update Knip itself (to at least v5.51.0) to have source mapping supported for compiled extensions (.svelte in this case).

Yup, that seems to have done the trick, at least if we ensure that the package is built before running Knip.

@JReinhold
Copy link
Contributor Author

@webpro I've had to undo the tsconfig.json changes because it was messing with our type checking and type definition generation. We'll have to find another solution in a follow-up PR, ideally in a Knip config instead.

@webpro
Copy link
Contributor

webpro commented Apr 29, 2025

Apologies for the hassle. Glad it's sorted for now anyway, I'll see what can do with the source mapping stuff. Thing is, there's two code paths using the function, and one can only work from within TS's module resolver, requiring the actual file to be on disk. The other we're discussing here can probably do without that requirement, also saving us from custom config. WIP :)

@JReinhold JReinhold merged commit 930f7e5 into next Apr 29, 2025
56 of 57 checks passed
@JReinhold JReinhold deleted the jeppe/fix-svelte-ts-dedent branch April 29, 2025 12:00
@github-actions github-actions bot mentioned this pull request Apr 29, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@ndelangen ndelangen ndelangen approved these changes

Assignees

@JReinhold JReinhold

Labels
bug ci:normal svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JReinhold @webpro @ndelangen
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy