Core: Delete shim addon packages #31728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Removes deprecated shim packages for the controls, backgrounds, and actions addons to stop re-publishing unused stubs.
- Deletes entire directories and files for shimmed addons (
package.json, source stubs, configs) - Eliminates the error stubs that provided migration guidance upon import
- Cleans up build/preview/manager entry points for these addons
Reviewed Changes
Copilot reviewed 63 out of 63 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| code/addons/controls/** | All shim package files removed |
| code/addons/backgrounds/** | All shim package files removed |
| code/addons/actions/** | All shim package files removed |
Comments suppressed due to low confidence (1)
code/addons/backgrounds/src/error.ts:1
- Removing these error stubs will cause users who still import the old addon to see a generic module-not-found error instead of a clear migration message. Consider keeping a minimal stub that throws a descriptive error pointing to the migration guide.
throw new Error(
There was a problem hiding this comment.
LGTM
63 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit dac6a1a.
☁️ Nx Cloud last updated this comment at |
valentinpalkovic
approved these changes
Jun 10, 2025
This was referenced Jun 10, 2025
Merged
JReinhold
pushed a commit
that referenced
this pull request
Jun 12, 2025
Core: Delete shim addon packages (cherry picked from commit 8f2c0db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I deleted the shim packages for addons from the monorepo.
Because they have 0 dependencies, and all they do is cause an error/warning to happen.. there's no reason for these packages to ever change anymore.
Publishing the same code over and over again is a waste.
Furthermore, we want to actually mark these packages as deprecated on the npm registry. We cannot do that effectively if we keep publishing new versions.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Removes deprecated shim addon packages from the Storybook monorepo as part of the v9.0 consolidation effort.
storybook/viewportinstead of@storybook/addon-viewport)