Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sveltejs/language-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: svelte-check-4.0.2
Choose a base ref
...
head repository: sveltejs/language-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: svelte-check-4.0.3
Choose a head ref
  • 9 commits
  • 56 files changed
  • 4 contributors

Commits on Sep 18, 2024

  1. fix: silence type error in old d.ts files

    svelte-jsx and svelte-shims are used for Svelte 3 only, and are likely out of date, yet we don't want to invest time into adjusting them anymore, therefore silence any type errors in it.
    Helps with #2498
    dummdidumm committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    73125a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    94a7352 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix: make no Svelte files found a warning (#2507)

    There were reports that this was too overzealous as some people use this potentially not knowing whether or not this is a Svelte-projects, too. Therefore only issue a warning instead of an error.
    dummdidumm authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e132b56 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e74f1d7 View commit details
    Browse the repository at this point in the history
  3. fix: revert additional two-way-binding checks (#2508)

    This reverts commit 8c080cf.
    
    This reverts #2477. Sadly, the idea didn't work out, as shown by two opened bug reports:
    
    - #2506: A type union can be narrowed on the input, but not on the way back out
    - #2494: A generic nested within a bound value is not properly resolved and not falling back to `any` (in #2477 we thought of the generic case, but only for when the generic is the whole value type, not when it's nested)
    
    For these reasons I don't see a way to properly implement #1392 at the moment.
    dummdidumm authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    81019d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. perf: auto import cache for svelte-kit language service proxy (#2513)

    #2464
    
    getPackageJsonsVisibleToFile and getGlobalTypingsCacheLocation are singleton so this should definitely be fine. The proxy language service has the exact list of entry files and the auto-typing also doesn't add any export so it should be fine to just proxy these methods.
    jasonlyu123 authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    35af691 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. breaking(svelte5): only generate function component shape in runes mo…

    …de (#2517)
    
    When a component is in runes mode and not using slots or events, adjust the output to only create the function type that mimics the underlying real shape of components in Svelte 5. This is a breaking change because previously the type was enhanced such that it also had the legacy class shape. As a result, users now may need to switch to `typeof Component` when using the component inside types.
    
    Sadly, due to a combination of requirements and TypeScript limitations, we need to always create both a legacy class component and function component type.
     - Constraints: Need to support Svelte 4 class component types, therefore we need to use __sveltets_2_ensureComponent to transform function components to classes
    - Limitations: TypeScript is not able to preserve generics during said transformation (i.e. there's no way to express keeping the generic etc)
    
    TODO Svelte 6/7: Switch this around and not use new Component in svelte2tsx anymore, which means we can remove the legacy class component. We need something like _ensureFnComponent then.
    dummdidumm authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    837b61f View commit details
    Browse the repository at this point in the history
  2. fix: check project files update more aggressively before assigning se…

    …rvice (#2518)
    
    #2516
    
    Most of the time, the didOpen request is earlier than the watcher event. So if the file doesn't exist in the GlobalSnapshotManager we manually invoke the project file update check. This won't cause 2 project files check because if the file already is a project file we won't check project files.
    jasonlyu123 authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7c76ec5 View commit details
    Browse the repository at this point in the history
  3. chore: upgrade to chokidar 4 (#2502)

    Also remove long-obsolete sapper handling
    benmccann authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fc2144b View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy