Skip to content

Ensure we always emit @keyframes correctly #16237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where we didn't always generate the @keyframes. Right now we only generate @keyframes if they are being used as one of the --animate-* utilities.

However, if your --animate-* definition is pretty long such that it is defined across multiple lines, then we didn't always generate the @keyframes for it.

This is because the animation name would look like 'my-animation-name\n' instead of 'my-animation-name'.

Fixes: #16227

@RobinMalfait RobinMalfait requested a review from a team as a code owner February 4, 2025 10:35
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4] Custom keyframes are not generated if the value of an animation variable contains a line break between the keyframe name and duration
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy