time: revert "use sharding for timer implementation" related changes #7226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges The work related to sharding the timer implementation has caused a measurable performance regression due to increased contention.
Noah-Kennedy
approved these changes
May 5, 2025
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
May 6, 2025
Bumps tokio from 1.44.2 to 1.45.0. Release notes Sourced from tokio's releases. Tokio v1.45.0 Added metrics: stabilize worker_total_busy_duration, worker_park_count, and worker_unpark_count (#6899, #7276) process: add Command::spawn_with (#7249) Changed io: do not require Unpin for some trait impls (#7204) rt: mark runtime::Handle as unwind safe (#7230) time: revert internal sharding implementation (#7226) Unstable rt: remove alt multi-threaded runtime (#7275) #6899: tokio-rs/tokio#6899 #7276: tokio-rs/tokio#7276 #7249: tokio-rs/tokio#7249 #7204: tokio-rs/tokio#7204 #7230: tokio-rs/tokio#7230 #7226: tokio-rs/tokio#7226 #7275: tokio-rs/tokio#7275 Commits 00754c8 chore: prepare Tokio v1.45.0 (#7308) 1ae9434 time: revert "use sharding for timer implementation" related changes (#7226) 8895bba ci: Test AArch64 Windows (#7288) 48ca254 time: update sleep documentation to reflect maximum allowed duration (#7302) a0af02a compat: add more documentation to tokio_util::compat (#7279) 0ce3a11 metrics: stabilize worker_park_count and worker_unpark_count (#7276) 1ea9ce1 ci: fix cfg!(miri) declarations in tests (#7286) 4d4d126 chore: prepare tokio-util v0.7.15 (#7283) 5490267 fs: update the mockall dev dependency to 0.13.0 (#7234) 1434b32 examples: improve echo example consistency (#7256) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work on sharding the timer implementation has caused a measurable performance regression due to increased contention.
This is a work-in-progress. I am posting the PR early to get CI to run.