Skip to content

test(extensions): migrate to createRuleTestCaseFunction #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

test(extensions): migrate to createRuleTestCaseFunction #183

merged 1 commit into from
Nov 15, 2024

Conversation

marcalexiei
Copy link
Contributor

Follow up of #176.

extensions rule right now has two messages:

eslint-plugin-import-x/src/rules/extensions.ts

Lines 169 to 173 in 75c4e36

messages: {
missing: 'Missing file extension {{extension}}for "{{importPath}}"',
unexpected:
'Unexpected use of file extension "{{extension}}" for "{{importPath}}"',
},

missing message is populate here:

eslint-plugin-import-x/src/rules/extensions.ts

Lines 262 to 266 in 75c4e36

messageId: 'missing',
data: {
extension: extension ? `"${extension}" ` : '',
importPath: importPathWithQueryString,
},

However testing this message with extensiondata property set like extension: '"js" ':

test({
  code: '...'
  errors: [
    { messageId: 'missing', data: { extension: '"js" ', importPath: './foo'  } }
  ]
})

Seems a bit awkward IMHO.

To simplify extension data property I added a separate message missingKnown.

I also refined Options type.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 7dc3480

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

SukkaW
SukkaW approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SukkaW SukkaW merged commit 14fc608 into un-ts:master Nov 15, 2024
21 checks passed
@marcalexiei marcalexiei deleted the feat/extensions branch March 15, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalexiei @SukkaW
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy