Skip to content

fix: remove buggy module-sync exports field #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2025
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented May 18, 2025

nodejs/node#57869


Important

Remove buggy module-sync export field from package.json.

  • Exports:
    • Remove module-sync export field from package.json to fix a bug related to module resolution.

This description was created by Ellipsis for 04d2481. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Updated the package configuration by removing the "module-sync" export entry. Only "import" and "require" options are now available for module exports.

@JounQin JounQin requested a review from Copilot May 18, 2025 06:00
@JounQin JounQin self-assigned this May 18, 2025
@JounQin JounQin added bug Something isn't working internal labels May 18, 2025
Copy link

changeset-bot bot commented May 18, 2025

🦋 Changeset detected

Latest commit: b8cd5d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented May 18, 2025

Walkthrough

The export map in the package.json file was updated by removing the "module-sync" entry from the main "." export key. The remaining export entries for "import" and "require" were left unchanged, maintaining their references to the respective module files.

Changes

File Change Summary
package.json Removed the "module-sync" entry from the "." export map, leaving only "import" and "require" entries.
.changeset/purple-penguins-beam.md Added a patch changelog noting the removal of the problematic module-sync export field in eslint-plugin-import-x.

Poem

The map was trimmed, a path set free,
"module-sync" waved goodbye with glee.
Now imports and requires stand side by side,
With cleaner routes, no need to hide.
A hop, a skip, a lighter pack—
The rabbit cheers, no looking back! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 04d2481 and b8cd5d4.

📒 Files selected for processing (1)
  • .changeset/purple-penguins-beam.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/purple-penguins-beam.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Walkthrough

This pull request addresses a bug by removing the module-sync exports field from the package.json file. The removal is intended to resolve issues related to the incorrect export paths that were causing problems.

Changes

File Summary
package.json Removed the module-sync exports field to fix buggy exports.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the now-buggy "module-sync" exports entry from package.json to correct the package export configuration.

  • Eliminate the unused module-sync export subpath that duplicated other entries.

Copy link

codacy-production bot commented May 18, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (62fedc5) 3603 3445 95.61%
Head commit (b8cd5d4) 3603 (+0) 3445 (+0) 95.61% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#332) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codesandbox-ci bot commented May 18, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (62fedc5) to head (b8cd5d4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          93       93           
  Lines        4816     4816           
  Branches     1822     1824    +2     
=======================================
  Hits         4627     4627           
  Misses        188      188           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 04d2481 in 40 seconds. Click for details.
  • Reviewed 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:21
  • Draft comment:
    Remove the 'module-sync' export (buggy according to Node.js issue #57869). Ensure this change is documented if any consumers relied on it.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_sPkFhoMgfvyL9ZtD

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

pkg-pr-new bot commented May 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-import-x@332

commit: b8cd5d4

Copy link

@un-ts un-ts deleted a comment from coderabbitai bot May 18, 2025
@JounQin
Copy link
Member Author

JounQin commented May 18, 2025

@coderabbitai review

Copy link

coderabbitai bot commented May 18, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@JounQin JounQin merged commit 0b3809b into master May 18, 2025
90 checks passed
@JounQin JounQin deleted the fix/module-sync branch May 18, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy