Make BaseHTTPResponse a base class of HTTP2Response #3311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
reviewed
Jan 24, 2024
src/urllib3/connectionpool.py
Outdated
| @@ -556,7 +556,7 @@ def _make_request( | |||
| # HTTP version | |||
| http_version, | |||
| response.status, | |||
| response.length_remaining, # type: ignore[attr-defined] | |||
| getattr(response, "length_remaining", None), | |||
There was a problem hiding this comment.
Can we add support for length_remaining in this PR?
There was a problem hiding this comment.
Do you mean adding self.length_remaining = 0 or actually handling it correctly?
There was a problem hiding this comment.
self.length_remaining = 0 seems appropriate, the actual implementation can happen in the streaming issue.
There was a problem hiding this comment.
Done. By the way, If we keep length_remaining eventually, this means we should probably add it to BaseHTTPResponse and fix the mypy error in the process.
There was a problem hiding this comment.
Agreed should be a part of BaseHTTPResponse.
|
Also looks like we need to add a test for |
illia-v
approved these changes
Jan 24, 2024
sethmlarson
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3297
As mentioned in #3297, it turns out we already had
version, an integer that tells us the HTTP version using a convention fromhttp.client(10 means HTTP/1.0, 11 means HTTP/1.1 and 20 means HTTP/2.0). I'm happy to add anhttp_versionstring field too.This pull request was sponsored by Elastic, my employer.