fix: avoid builtStart during vite optimize (#19356)

patak-dev · web-flow · commit fdb36e076969 · 2025-02-05T06:57:46.000+01:00
diff --git a/packages/vite/src/node/idResolver.ts b/packages/vite/src/node/idResolver.ts
@@ -72,6 +72,8 @@ export function createIdResolver(
             idOnly: true,
           }),
         ],
+        undefined,
+        false,
       )
       pluginContainerMap.set(environment, pluginContainer)
     }
@@ -92,6 +94,8 @@ export function createIdResolver(
       pluginContainer = await createEnvironmentPluginContainer(
         environment as Environment,
         [aliasPlugin({ entries: environment.config.resolve.alias })],
+        undefined,
+        false,
       )
       aliasOnlyPluginContainerMap.set(environment, pluginContainer)
     }
diff --git a/packages/vite/src/node/optimizer/scan.ts b/packages/vite/src/node/optimizer/scan.ts
@@ -67,6 +67,8 @@ export class ScanEnvironment extends BaseEnvironment {
     this._pluginContainer = await createEnvironmentPluginContainer(
       this,
       this.plugins,
+      undefined,
+      false,
     )
   }
 }
diff --git a/packages/vite/src/node/server/pluginContainer.ts b/packages/vite/src/node/server/pluginContainer.ts
@@ -136,11 +136,13 @@ export async function createEnvironmentPluginContainer(
   environment: Environment,
   plugins: Plugin[],
   watcher?: FSWatcher,
+  autoStart = true,
 ): Promise<EnvironmentPluginContainer> {
   const container = new EnvironmentPluginContainer(
     environment,
     plugins,
     watcher,
+    autoStart,
   )
   await container.resolveRollupOptions()
   return container
@@ -183,7 +185,9 @@ class EnvironmentPluginContainer {
     public environment: Environment,
     public plugins: Plugin[],
     public watcher?: FSWatcher,
+    autoStart = true,
   ) {
+    this._started = !autoStart
     this.minimalContext = new MinimalPluginContext(
       { rollupVersion, watchMode: true },
       environment,

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,8 @@ export function createIdResolver(`
`72`	`72`	`idOnly: true,`
`73`	`73`	`}),`
`74`	`74`	`],`
	`75`	`+ undefined,`
	`76`	`+ false,`
`75`	`77`	`)`
`76`	`78`	`pluginContainerMap.set(environment, pluginContainer)`
`77`	`79`	`}`
`@@ -92,6 +94,8 @@ export function createIdResolver(`
`92`	`94`	`pluginContainer = await createEnvironmentPluginContainer(`
`93`	`95`	`environment as Environment,`
`94`	`96`	`[aliasPlugin({ entries: environment.config.resolve.alias })],`
	`97`	`+ undefined,`
	`98`	`+ false,`
`95`	`99`	`)`
`96`	`100`	`aliasOnlyPluginContainerMap.set(environment, pluginContainer)`
`97`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,8 @@ export class ScanEnvironment extends BaseEnvironment {`
`67`	`67`	`this._pluginContainer = await createEnvironmentPluginContainer(`
`68`	`68`	`this,`
`69`	`69`	`this.plugins,`
	`70`	`+ undefined,`
	`71`	`+ false,`
`70`	`72`	`)`
`71`	`73`	`}`
`72`	`74`	`}`