perf(utils): improve performance of numberToPos
#20244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed an inconsistency in the previous test snapshot: when receiving an offset of 8, it returns |
sapphi-red
reviewed
Jun 20, 2025
There was a problem hiding this comment.
Thanks! The change looks good to me.
Would you add some tests for numberToPos below here so that we can catch the bug you found more easily?
vite/packages/vite/src/node/__tests__/utils.spec.ts
Lines 229 to 246 in 657c2fa
sapphi-red
approved these changes
Jun 20, 2025
bluwy
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
numberToPosfunction, achieving 1.66x-2.27x performance improvement across different JavaScript runtimes. The refactored implementation also provides clearer and more maintainable code.Benchmarks
The code of benchmarks is shown at Stackblitz.
Performance was measured using a 9,179-character test file across multiple runtimes locally.
Behavior Changes
The current implementation return positions like
{ line: /* previous line */, column: /* line length including newline */ }. The new implementation consistently return the start position of the next line like{ line: /* exact the line */, column: 0 }, which better aligns with the0-basedcolumn described in thePostype comments.vite/packages/vite/src/node/utils.ts
Lines 471 to 476 in 657c2fa