fix: support custom toString method in %s format (#7637)

pengooseDev · web-flow · commit 46d93a2e89cd · 2025-03-11T14:49:29.000+01:00
diff --git a/packages/utils/src/display.ts b/packages/utils/src/display.ts
@@ -110,6 +110,9 @@ export function format(...args: unknown[]): string {
           return '-0'
         }
         if (typeof value === 'object' && value !== null) {
+          if (typeof value.toString === 'function' && value.toString !== Object.prototype.toString) {
+            return value.toString()
+          }
           return inspect(value, { depth: 0, colors: false })
         }
         return String(value)
diff --git a/test/core/test/utils-display.spec.ts b/test/core/test/utils-display.spec.ts
@@ -18,6 +18,15 @@ describe('format', () => {
     ['%s', -0],
     ['%s', null],
     ['%s', null, 'next'],
+    [
+      '%s',
+      new (class {
+        constructor(public value: string) {}
+        toString() {
+          return this.value
+        }
+      })('string value'),
+    ],
     ['%d', 100],
     ['%d', 100n],
     ['%d', null],

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,9 @@ export function format(...args: unknown[]): string {`
`110`	`110`	`return '-0'`
`111`	`111`	`}`
`112`	`112`	`if (typeof value === 'object' && value !== null) {`
	`113`	`+ if (typeof value.toString === 'function' && value.toString !== Object.prototype.toString) {`
	`114`	`+ return value.toString()`
	`115`	`+ }`
`113`	`116`	`return inspect(value, { depth: 0, colors: false })`
`114`	`117`	`}`
`115`	`118`	`return String(value)`