fix(types): make parameters non-nullable for Playwright options (#6989)

apple-yagi · web-flow · commit fe2a187f92e2 · 2024-12-01T18:52:34.000+09:00
diff --git a/packages/browser/providers/playwright.d.ts b/packages/browser/providers/playwright.d.ts
@@ -27,13 +27,13 @@ declare module 'vitest/node' {
   }
 }
 
-type PWHoverOptions = Parameters<Page['hover']>[1]
-type PWClickOptions = Parameters<Page['click']>[1]
-type PWDoubleClickOptions = Parameters<Page['dblclick']>[1]
-type PWFillOptions = Parameters<Page['fill']>[2]
-type PWScreenshotOptions = Parameters<Page['screenshot']>[0]
-type PWSelectOptions = Parameters<Page['selectOption']>[2]
-type PWDragAndDropOptions = Parameters<Page['dragAndDrop']>[2]
+type PWHoverOptions = NonNullable<Parameters<Page['hover']>[1]>
+type PWClickOptions = NonNullable<Parameters<Page['click']>[1]>
+type PWDoubleClickOptions = NonNullable<Parameters<Page['dblclick']>[1]>
+type PWFillOptions = NonNullable<Parameters<Page['fill']>[2]>
+type PWScreenshotOptions = NonNullable<Parameters<Page['screenshot']>[0]>
+type PWSelectOptions = NonNullable<Parameters<Page['selectOption']>[2]>
+type PWDragAndDropOptions = NonNullable<Parameters<Page['dragAndDrop']>[2]>
 
 declare module '@vitest/browser/context' {
   export interface UserEventHoverOptions extends PWHoverOptions {}
diff --git a/packages/browser/src/node/commands/hover.ts b/packages/browser/src/node/commands/hover.ts
@@ -16,7 +16,7 @@ export const hover: UserEventCommand<UserEvent['hover']> = async (
   }
   else if (context.provider instanceof WebdriverBrowserProvider) {
     const browser = context.browser
-    await browser.$(selector).moveTo(options)
+    await browser.$(selector).moveTo(options as any)
   }
   else {
     throw new TypeError(`Provider "${context.provider.name}" does not support hover`)

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export const hover: UserEventCommand<UserEvent['hover']> = async (`
`16`	`16`	`}`
`17`	`17`	`else if (context.provider instanceof WebdriverBrowserProvider) {`
`18`	`18`	`const browser = context.browser`
`19`		`- await browser.$(selector).moveTo(options)`
	`19`	`+ await browser.$(selector).moveTo(options as any)`
`20`	`20`	`}`
`21`	`21`	`else {`
`22`	`22`	throw new TypeError(`Provider "${context.provider.name}" does not support hover`)