fix(compiler-core): identifiers in function parameters should not be inferred as references (#13548)

zhiyuanzmj · web-flow · commit 9b029239edf8 · 2025-07-23T08:41:50.000+08:00
diff --git a/packages/compiler-core/__tests__/utils.spec.ts b/packages/compiler-core/__tests__/utils.spec.ts
@@ -1,4 +1,9 @@
-import type { ExpressionNode, TransformContext } from '../src'
+import { babelParse, walkIdentifiers } from '@vue/compiler-sfc'
+import {
+  type ExpressionNode,
+  type TransformContext,
+  isReferencedIdentifier,
+} from '../src'
 import { type Position, createSimpleExpression } from '../src/ast'
 import {
   advancePositionWithClone,
@@ -115,3 +120,18 @@ test('toValidAssetId', () => {
     '_component_test_2797935797_1',
   )
 })
+
+describe('isReferencedIdentifier', () => {
+  test('identifiers in function parameters should not be inferred as references', () => {
+    expect.assertions(4)
+    const ast = babelParse(`(({ title }) => [])`)
+    walkIdentifiers(
+      ast.program.body[0],
+      (node, parent, parentStack, isReference) => {
+        expect(isReference).toBe(false)
+        expect(isReferencedIdentifier(node, parent, parentStack)).toBe(false)
+      },
+      true,
+    )
+  })
+})
diff --git a/packages/compiler-core/src/babelUtils.ts b/packages/compiler-core/src/babelUtils.ts
@@ -122,7 +122,7 @@ export function isReferencedIdentifier(
     return false
   }
 
-  if (isReferenced(id, parent)) {
+  if (isReferenced(id, parent, parentStack[parentStack.length - 2])) {
     return true
   }
 
@@ -132,7 +132,8 @@ export function isReferencedIdentifier(
     case 'AssignmentExpression':
     case 'AssignmentPattern':
       return true
-    case 'ObjectPattern':
+    case 'ObjectProperty':
+      return parent.key !== id && isInDestructureAssignment(parent, parentStack)
     case 'ArrayPattern':
       return isInDestructureAssignment(parent, parentStack)
   }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ export function isReferencedIdentifier(`
`122`	`122`	`return false`
`123`	`123`	`}`
`124`	`124`
`125`		`- if (isReferenced(id, parent)) {`
	`125`	`+ if (isReferenced(id, parent, parentStack[parentStack.length - 2])) {`
`126`	`126`	`return true`
`127`	`127`	`}`
`128`	`128`
`@@ -132,7 +132,8 @@ export function isReferencedIdentifier(`
`132`	`132`	`case 'AssignmentExpression':`
`133`	`133`	`case 'AssignmentPattern':`
`134`	`134`	`return true`
`135`		`- case 'ObjectPattern':`
	`135`	`+ case 'ObjectProperty':`
	`136`	`+ return parent.key !== id && isInDestructureAssignment(parent, parentStack)`
`136`	`137`	`case 'ArrayPattern':`
`137`	`138`	`return isInDestructureAssignment(parent, parentStack)`
`138`	`139`	`}`