fix(compiler-core): ensure mapping is added only if node source is available (#13285)

edison1105 · web-flow · commit d37a2ac59d90 · 2025-05-16T08:22:37.000+08:00
close #13261 close vitejs/vite-plugin-vue#368
diff --git a/packages/compiler-core/src/codegen.ts b/packages/compiler-core/src/codegen.ts
@@ -188,7 +188,9 @@ function createCodegenContext(
               name = content
             }
           }
-          addMapping(node.loc.start, name)
+          if (node.loc.source) {
+            addMapping(node.loc.start, name)
+          }
         }
         if (newlineIndex === NewlineType.Unknown) {
           // multiple newlines, full iteration
@@ -225,7 +227,7 @@ function createCodegenContext(
             context.column = code.length - newlineIndex
           }
         }
-        if (node && node.loc !== locStub) {
+        if (node && node.loc !== locStub && node.loc.source) {
           addMapping(node.loc.end)
         }
       }
diff --git a/packages/compiler-sfc/__tests__/compileTemplate.spec.ts b/packages/compiler-sfc/__tests__/compileTemplate.spec.ts
@@ -157,6 +157,35 @@ test('source map', () => {
   ).toMatchObject(getPositionInCode(template.content, `foobar`))
 })
 
+test('source map: v-if generated comment should not have original position', () => {
+  const template = parse(
+    `
+      <template>
+        <div v-if="true"></div>
+      </template>
+    `,
+    { filename: 'example.vue', sourceMap: true },
+  ).descriptor.template!
+
+  const { code, map } = compile({
+    filename: 'example.vue',
+    source: template.content,
+  })
+
+  expect(map!.sources).toEqual([`example.vue`])
+  expect(map!.sourcesContent).toEqual([template.content])
+
+  const consumer = new SourceMapConsumer(map as RawSourceMap)
+  const commentNode = code.match(/_createCommentVNode\("v-if", true\)/)
+  expect(commentNode).not.toBeNull()
+  const commentPosition = getPositionInCode(code, commentNode![0])
+  const originalPosition = consumer.originalPositionFor(commentPosition)
+  // the comment node should not be mapped to the original source
+  expect(originalPosition.column).toBeNull()
+  expect(originalPosition.line).toBeNull()
+  expect(originalPosition.source).toBeNull()
+})
+
 test('should work w/ AST from descriptor', () => {
   const source = `
   <template>

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,9 @@ function createCodegenContext(`
`188`	`188`	`name = content`
`189`	`189`	`}`
`190`	`190`	`}`
`191`		`- addMapping(node.loc.start, name)`
	`191`	`+ if (node.loc.source) {`
	`192`	`+ addMapping(node.loc.start, name)`
	`193`	`+ }`
`192`	`194`	`}`
`193`	`195`	`if (newlineIndex === NewlineType.Unknown) {`
`194`	`196`	`// multiple newlines, full iteration`
`@@ -225,7 +227,7 @@ function createCodegenContext(`
`225`	`227`	`context.column = code.length - newlineIndex`
`226`	`228`	`}`
`227`	`229`	`}`
`228`		`- if (node && node.loc !== locStub) {`
	`230`	`+ if (node && node.loc !== locStub && node.loc.source) {`
`229`	`231`	`addMapping(node.loc.end)`
`230`	`232`	`}`
`231`	`233`	`}`