fix: allow matching body for delete requests

pbomb · pbomb · commit 891197c37eb6 · 2025-03-03T10:09:15.000-07:00
diff --git a/packages/fetch-mock/src/Matchers.ts b/packages/fetch-mock/src/Matchers.ts
@@ -212,7 +212,7 @@ const getBodyMatcher: MatcherGenerator = (route) => {
 	}
 
 	return ({ options: { body, method = 'get' } }) => {
-		if (['get', 'head', 'delete'].includes(method.toLowerCase())) {
+		if (['get', 'head'].includes(method.toLowerCase())) {
 			// GET requests don’t send a body so even if it exists in the options
 			// we treat as no body because it would never actually make it to the server
 			// in the application code
diff --git a/packages/fetch-mock/src/__tests__/Matchers/body.test.js b/packages/fetch-mock/src/__tests__/Matchers/body.test.js
@@ -144,6 +144,25 @@ describe('body matching', () => {
 			).toBe(true);
 		});
 
+		it('should match if request is delete', () => {
+			const route = new Route({
+				body: { foo: 'bar' },
+				method: 'delete',
+				response: 200,
+			});
+
+			expect(
+				route.matcher({
+					url: 'http://a.com/',
+					options: {
+						method: 'DELETE',
+						body: JSON.stringify({ foo: 'bar' }),
+						headers: { 'Content-Type': 'application/json' },
+					},
+				}),
+			).toBe(true);
+		});
+
 		describe('partial body matching', () => {
 			it('match when missing properties', () => {
 				const route = new Route({

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ const getBodyMatcher: MatcherGenerator = (route) => {`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`return ({ options: { body, method = 'get' } }) => {`
`215`		`- if (['get', 'head', 'delete'].includes(method.toLowerCase())) {`
	`215`	`+ if (['get', 'head'].includes(method.toLowerCase())) {`
`216`	`216`	`// GET requests don’t send a body so even if it exists in the options`
`217`	`217`	`// we treat as no body because it would never actually make it to the server`
`218`	`218`	`// in the application code`