Skip to content

Commit 1a0abe4

Browse files
authored
Add missing position entry according to PositionNode (#23310)
Add missing normal entry according to NormalNode Add missing Angle/Trigonometry functions
1 parent be80adf commit 1a0abe4

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

examples/jsm/node-editor/accessors/NormalEditor.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ export class NormalEditor extends BaseNode {
1313
const optionsField = new SelectInput( [
1414
{ name: 'Local', value: NormalNode.LOCAL },
1515
{ name: 'World', value: NormalNode.WORLD },
16-
{ name: 'View', value: NormalNode.VIEW }
16+
{ name: 'View', value: NormalNode.VIEW },
17+
{ name: 'Geometry', value: NormalNode.GEOMETRY },
1718
], NormalNode.LOCAL ).onChange( () => {
1819

1920
node.scope = optionsField.getValue();

examples/jsm/node-editor/accessors/PositionEditor.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ export class PositionEditor extends BaseNode {
1313
const optionsField = new SelectInput( [
1414
{ name: 'Local', value: PositionNode.LOCAL },
1515
{ name: 'World', value: PositionNode.WORLD },
16-
{ name: 'View', value: PositionNode.VIEW }
16+
{ name: 'View', value: PositionNode.VIEW },
17+
{ name: 'ViewDirection', value: PositionNode.VIEW_DIRECTION },
1718
], PositionNode.LOCAL ).onChange( () => {
1819

1920
node.scope = optionsField.getValue();

examples/jsm/node-editor/math/TrigonometryEditor.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,19 @@ export class TrigonometryEditor extends BaseNode {
1010

1111
const node = new MathNode( MathNode.SIN, DEFAULT_VALUE );
1212

13-
super( 'Trigonometry', 1, node, 175 );
13+
super( 'Angle / Trigonometry', 1, node, 220 );
1414

1515
const optionsField = new SelectInput( [
16+
{ name: 'Radian', value: MathNode.RAD },
17+
{ name: 'Degree', value: MathNode.DEG },
18+
1619
{ name: 'Sin', value: MathNode.SIN },
1720
{ name: 'Cos', value: MathNode.COS },
18-
{ name: 'Tan', value: MathNode.TAN }
21+
{ name: 'Tan', value: MathNode.TAN },
22+
23+
{ name: 'asin', value: MathNode.ASIN },
24+
{ name: 'acos', value: MathNode.ACOS },
25+
{ name: 'atan', value: MathNode.ATAN },
1926
], MathNode.SIN ).onChange( () => {
2027

2128
node.method = optionsField.getValue();

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy