fix: inc prerelease with numeric preid (#380)

ntkme · web-flow · commit 802e16174fe2 · 2022-04-09T20:06:20.000-07:00
diff --git a/classes/semver.js b/classes/semver.js
@@ -265,7 +265,7 @@ class SemVer {
         if (identifier) {
           // 1.2.0-beta.1 bumps to 1.2.0-beta.2,
           // 1.2.0-beta.fooblz or 1.2.0-beta bumps to 1.2.0-beta.0
-          if (this.prerelease[0] === identifier) {
+          if (compareIdentifiers(this.prerelease[0], identifier) === 0) {
             if (isNaN(this.prerelease[1])) {
               this.prerelease = [identifier, 0]
             }
diff --git a/test/fixtures/increments.js b/test/fixtures/increments.js
@@ -82,4 +82,9 @@ module.exports = [
   ['1.2.0-1', 'minor', '1.2.0', false, 'dev'],
   ['1.0.0-1', 'major', '1.0.0', 'dev'],
   ['1.2.3-dev.bar', 'prerelease', '1.2.3-dev.0', false, 'dev'],
+
+  ['1.2.3-0', 'prerelease', '1.2.3-1.0', false, '1'],
+  ['1.2.3-1.0', 'prerelease', '1.2.3-1.1', false, '1'],
+  ['1.2.3-1.1', 'prerelease', '1.2.3-1.2', false, '1'],
+  ['1.2.3-1.1', 'prerelease', '1.2.3-2.0', false, '2'],
 ]

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ class SemVer {`
`265`	`265`	`if (identifier) {`
`266`	`266`	`// 1.2.0-beta.1 bumps to 1.2.0-beta.2,`
`267`	`267`	`// 1.2.0-beta.fooblz or 1.2.0-beta bumps to 1.2.0-beta.0`
`268`		`- if (this.prerelease[0] === identifier) {`
	`268`	`+ if (compareIdentifiers(this.prerelease[0], identifier) === 0) {`
`269`	`269`	`if (isNaN(this.prerelease[1])) {`
`270`	`270`	`this.prerelease = [identifier, 0]`
`271`	`271`	`}`