feat: improve minification for --target es5 (#664)

Nikaple · egoist · web-flow · commit 34df1da747a2 · 2022-07-25T22:57:57.000+08:00
* feat: improve minification for `--target es5`

* remove .only

Co-authored-by: EGOIST &lt;0x142857@gmail.com&gt;
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/plugins/es5.ts b/src/plugins/es5.ts
@@ -35,6 +35,12 @@ export const es5 = (): Plugin => {
           parser: {
             syntax: 'ecmascript',
           },
+          minify: this.options.minify ? {
+            compress: false,
+            mangle: {
+              reserved: this.options.globalName ? [this.options.globalName] : []
+            },
+          } : undefined,
         },
       })
       return {
diff --git a/test/index.test.ts b/test/index.test.ts
@@ -443,7 +443,6 @@ test('svelte: typescript support', async () => {
   expect(output).toContain('// Component.svelte')
 })
 
-
 test('onSuccess', async () => {
   const { logs } = await run(
     getTestName(),
@@ -460,11 +459,9 @@ test('onSuccess', async () => {
 })
 
 test('onSuccess: use a function from config file', async () => {
-  const { logs } = await run(
-    getTestName(),
-    {
-      'input.ts': "console.log('test');",
-      'tsup.config.ts': `
+  const { logs } = await run(getTestName(), {
+    'input.ts': "console.log('test');",
+    'tsup.config.ts': `
         export default {
           onSuccess: async () => {
             console.log('hello')
@@ -475,9 +472,8 @@ test('onSuccess: use a function from config file', async () => {
               }, 1_000)
             })
           }
-        }`
-    },
-  )
+        }`,
+  })
 
   expect(logs.includes('hello')).toEqual(true)
   expect(logs.includes('world')).toEqual(true)
@@ -824,6 +820,38 @@ test('es5 target', async () => {
   expect(outFiles).toEqual(['input.js'])
 })
 
+test('es5 minify', async () => {
+  const { getFileContent, outFiles } = await run(
+    getTestName(),
+    {
+      'input.ts': `
+    export class Foo {
+      hi (): void {
+        let a = () => 'foo'
+
+        console.log(a())
+      }
+    }
+    `,
+    },
+    {
+      flags: [
+        '--target',
+        'es5',
+        '--format',
+        'iife',
+        '--globalName',
+        'FooAPI',
+        '--minify',
+      ],
+    }
+  )
+  expect(outFiles).toEqual(['input.global.js'])
+  const iifeBundle = await getFileContent('dist/input.global.js')
+  expect(iifeBundle).toMatch(/var FooAPI/)
+  expect(iifeBundle).not.toMatch(/createClass/)
+})
+
 test('multiple targets', async () => {
   const { output, outFiles } = await run(
     getTestName(),
