feat: false negative with property option in id-match (#15474)

snitin315 · web-flow · commit 127f524337f9 · 2022-01-06T15:30:33.000+01:00
Fixes #15443
diff --git a/lib/rules/id-match.js b/lib/rules/id-match.js
@@ -250,7 +250,7 @@ module.exports = {
                     }
 
                     // never check properties or always ignore destructuring
-                    if (!checkProperties || (ignoreDestructuring && isInsideObjectPattern(node))) {
+                    if ((!checkProperties && !parent.computed) || (ignoreDestructuring && isInsideObjectPattern(node))) {
                         return;
                     }
 
diff --git a/tests/lib/rules/id-match.js b/tests/lib/rules/id-match.js
@@ -894,6 +894,26 @@ ruleTester.run("id-match", rule, {
                     type: "Identifier"
                 }
             ]
+        },
+
+        // https://github.com/eslint/eslint/issues/15443
+        {
+            code: `
+            const foo = {
+                [a]: 1,
+            };
+            `,
+            options: ["^[^a]", {
+                properties: false,
+                onlyDeclarations: false
+            }],
+            parserOptions: { ecmaVersion: 2022 },
+            errors: [
+                {
+                    message: "Identifier 'a' does not match the pattern '^[^a]'.",
+                    type: "Identifier"
+                }
+            ]
         }
     ]
 });

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ module.exports = {`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`// never check properties or always ignore destructuring`
`253`		`- if (!checkProperties \|\| (ignoreDestructuring && isInsideObjectPattern(node))) {`
	`253`	`+ if ((!checkProperties && !parent.computed) \|\| (ignoreDestructuring && isInsideObjectPattern(node))) {`
`254`	`254`	`return;`
`255`	`255`	`}`
`256`	`256`