Skip to content

Commit db15802

Browse files
fasttimefasttime
authored
fix: Add property fatalErrorCount to ignored file results (#15520)
Fixes #15510
1 parent 03ac8cf commit db15802

File tree

4 files changed

+23
-2
lines changed

4 files changed

+23
-2
lines changed

‎lib/cli-engine/cli-engine.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ const validFixTypes = new Set(["directive", "problem", "suggestion", "layout"]);
9292
* @property {string} filePath The path to the file that was linted.
9393
* @property {LintMessage[]} messages All of the messages for the result.
9494
* @property {number} errorCount Number of errors for the result.
95+
* @property {number} fatalErrorCount Number of fatal errors for the result.
9596
* @property {number} warningCount Number of warnings for the result.
9697
* @property {number} fixableErrorCount Number of fixable errors for the result.
9798
* @property {number} fixableWarningCount Number of fixable warnings for the result.
@@ -104,6 +105,7 @@ const validFixTypes = new Set(["directive", "problem", "suggestion", "layout"]);
104105
* @typedef {Object} LintReport
105106
* @property {LintResult[]} results All of the result.
106107
* @property {number} errorCount Number of errors for the result.
108+
* @property {number} fatalErrorCount Number of fatal errors for the result.
107109
* @property {number} warningCount Number of warnings for the result.
108110
* @property {number} fixableErrorCount Number of fixable errors for the result.
109111
* @property {number} fixableWarningCount Number of fixable warnings for the result.
@@ -308,6 +310,7 @@ function createIgnoreResult(filePath, baseDir) {
308310
}
309311
],
310312
errorCount: 0,
313+
fatalErrorCount: 0,
311314
warningCount: 1,
312315
fixableErrorCount: 0,
313316
fixableWarningCount: 0

‎lib/eslint/eslint.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ const { version } = require("../../package.json");
7979
* @property {string} filePath The path to the file that was linted.
8080
* @property {LintMessage[]} messages All of the messages for the result.
8181
* @property {number} errorCount Number of errors for the result.
82+
* @property {number} fatalErrorCount Number of fatal errors for the result.
8283
* @property {number} warningCount Number of warnings for the result.
8384
* @property {number} fixableErrorCount Number of fixable errors for the result.
8485
* @property {number} fixableWarningCount Number of fixable warnings for the result.

‎tests/lib/cli-engine/cli-engine.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ describe("CLIEngine", () => {
235235
assert.strictEqual(report.results.length, 1);
236236
assert.strictEqual(report.errorCount, 0);
237237
assert.strictEqual(report.warningCount, 1);
238+
assert.strictEqual(report.fatalErrorCount, 0);
238239
assert.strictEqual(report.fixableErrorCount, 0);
239240
assert.strictEqual(report.fixableWarningCount, 0);
240241
assert.strictEqual(report.results[0].filePath, getFixturePath("passing.js"));
@@ -243,6 +244,7 @@ describe("CLIEngine", () => {
243244
assert.isUndefined(report.results[0].messages[0].output);
244245
assert.strictEqual(report.results[0].errorCount, 0);
245246
assert.strictEqual(report.results[0].warningCount, 1);
247+
assert.strictEqual(report.results[0].fatalErrorCount, 0);
246248
assert.strictEqual(report.results[0].fixableErrorCount, 0);
247249
assert.strictEqual(report.results[0].fixableWarningCount, 0);
248250
});
@@ -982,6 +984,7 @@ describe("CLIEngine", () => {
982984
assert.strictEqual(report.results.length, 1);
983985
assert.strictEqual(report.results[0].errorCount, 0);
984986
assert.strictEqual(report.results[0].warningCount, 1);
987+
assert.strictEqual(report.results[0].fatalErrorCount, 0);
985988
assert.strictEqual(report.results[0].fixableErrorCount, 0);
986989
assert.strictEqual(report.results[0].fixableWarningCount, 0);
987990
assert.strictEqual(report.results[0].messages[0].message, expectedMsg);
@@ -1045,6 +1048,7 @@ describe("CLIEngine", () => {
10451048
assert.strictEqual(report.results.length, 1);
10461049
assert.strictEqual(report.results[0].errorCount, 0);
10471050
assert.strictEqual(report.results[0].warningCount, 1);
1051+
assert.strictEqual(report.results[0].fatalErrorCount, 0);
10481052
assert.strictEqual(report.results[0].fixableErrorCount, 0);
10491053
assert.strictEqual(report.results[0].fixableWarningCount, 0);
10501054
assert.strictEqual(report.results[0].messages[0].message, expectedMsg);
@@ -1066,6 +1070,7 @@ describe("CLIEngine", () => {
10661070
assert.strictEqual(report.results.length, 1);
10671071
assert.strictEqual(report.results[0].errorCount, 0);
10681072
assert.strictEqual(report.results[0].warningCount, 1);
1073+
assert.strictEqual(report.results[0].fatalErrorCount, 0);
10691074
assert.strictEqual(report.results[0].fixableErrorCount, 0);
10701075
assert.strictEqual(report.results[0].fixableWarningCount, 0);
10711076
assert.strictEqual(report.results[0].messages[0].message, expectedMsg);
@@ -1415,13 +1420,15 @@ describe("CLIEngine", () => {
14151420
assert.strictEqual(report.results.length, 1);
14161421
assert.strictEqual(report.errorCount, 0);
14171422
assert.strictEqual(report.warningCount, 1);
1423+
assert.strictEqual(report.fatalErrorCount, 0);
14181424
assert.strictEqual(report.fixableErrorCount, 0);
14191425
assert.strictEqual(report.fixableWarningCount, 0);
14201426
assert.strictEqual(report.results[0].filePath, filePath);
14211427
assert.strictEqual(report.results[0].messages[0].severity, 1);
14221428
assert.strictEqual(report.results[0].messages[0].message, "File ignored because of a matching ignore pattern. Use \"--no-ignore\" to override.");
14231429
assert.strictEqual(report.results[0].errorCount, 0);
14241430
assert.strictEqual(report.results[0].warningCount, 1);
1431+
assert.strictEqual(report.results[0].fatalErrorCount, 0);
14251432
assert.strictEqual(report.results[0].fixableErrorCount, 0);
14261433
assert.strictEqual(report.results[0].fixableWarningCount, 0);
14271434
});
@@ -4824,12 +4831,14 @@ describe("CLIEngine", () => {
48244831
assert.lengthOf(report.results, 1);
48254832
assert.strictEqual(report.errorCount, 0);
48264833
assert.strictEqual(report.warningCount, 1);
4834+
assert.strictEqual(report.fatalErrorCount, 0);
48274835
assert.strictEqual(report.fixableErrorCount, 0);
48284836
assert.strictEqual(report.fixableWarningCount, 0);
48294837
assert.strictEqual(report.results[0].errorCount, 0);
48304838
assert.strictEqual(report.results[0].warningCount, 1);
4831-
assert.strictEqual(report.fixableErrorCount, 0);
4832-
assert.strictEqual(report.fixableWarningCount, 0);
4839+
assert.strictEqual(report.results[0].fatalErrorCount, 0);
4840+
assert.strictEqual(report.results[0].fixableErrorCount, 0);
4841+
assert.strictEqual(report.results[0].fixableWarningCount, 0);
48334842
});
48344843

48354844
it("should return source code of file in the `source` property", () => {

‎tests/lib/eslint/eslint.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ describe("ESLint", () => {
324324
assert.strictEqual(results[0].messages[0].output, void 0);
325325
assert.strictEqual(results[0].errorCount, 0);
326326
assert.strictEqual(results[0].warningCount, 1);
327+
assert.strictEqual(results[0].fatalErrorCount, 0);
327328
assert.strictEqual(results[0].fixableErrorCount, 0);
328329
assert.strictEqual(results[0].fixableWarningCount, 0);
329330
assert.strictEqual(results[0].usedDeprecatedRules.length, 0);
@@ -1044,6 +1045,7 @@ describe("ESLint", () => {
10441045
assert.strictEqual(results.length, 1);
10451046
assert.strictEqual(results[0].errorCount, 0);
10461047
assert.strictEqual(results[0].warningCount, 1);
1048+
assert.strictEqual(results[0].fatalErrorCount, 0);
10471049
assert.strictEqual(results[0].fixableErrorCount, 0);
10481050
assert.strictEqual(results[0].fixableWarningCount, 0);
10491051
assert.strictEqual(results[0].messages[0].message, expectedMsg);
@@ -1105,6 +1107,7 @@ describe("ESLint", () => {
11051107
assert.strictEqual(results.length, 1);
11061108
assert.strictEqual(results[0].errorCount, 0);
11071109
assert.strictEqual(results[0].warningCount, 1);
1110+
assert.strictEqual(results[0].fatalErrorCount, 0);
11081111
assert.strictEqual(results[0].fixableErrorCount, 0);
11091112
assert.strictEqual(results[0].fixableWarningCount, 0);
11101113
assert.strictEqual(results[0].messages[0].message, expectedMsg);
@@ -1127,6 +1130,7 @@ describe("ESLint", () => {
11271130
assert.strictEqual(results.length, 1);
11281131
assert.strictEqual(results[0].errorCount, 0);
11291132
assert.strictEqual(results[0].warningCount, 1);
1133+
assert.strictEqual(results[0].fatalErrorCount, 0);
11301134
assert.strictEqual(results[0].fixableErrorCount, 0);
11311135
assert.strictEqual(results[0].fixableWarningCount, 0);
11321136
assert.strictEqual(results[0].messages[0].message, expectedMsg);
@@ -1413,6 +1417,7 @@ describe("ESLint", () => {
14131417
assert.strictEqual(results[0].messages[0].message, "File ignored because of a matching ignore pattern. Use \"--no-ignore\" to override.");
14141418
assert.strictEqual(results[0].errorCount, 0);
14151419
assert.strictEqual(results[0].warningCount, 1);
1420+
assert.strictEqual(results[0].fatalErrorCount, 0);
14161421
assert.strictEqual(results[0].fixableErrorCount, 0);
14171422
assert.strictEqual(results[0].fixableWarningCount, 0);
14181423
});
@@ -4822,6 +4827,9 @@ describe("ESLint", () => {
48224827
assert.strictEqual(results.length, 1);
48234828
assert.strictEqual(results[0].errorCount, 0);
48244829
assert.strictEqual(results[0].warningCount, 1);
4830+
assert.strictEqual(results[0].fatalErrorCount, 0);
4831+
assert.strictEqual(results[0].fixableErrorCount, 0);
4832+
assert.strictEqual(results[0].fixableWarningCount, 0);
48254833
});
48264834

48274835
it("should return source code of file in the `source` property", async () => {

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy