fix(js): resolve imports as native node apis before npm modules (#18358)

FrozenPandaz · web-flow · commit 0fd8859c37c3 · 2023-07-28T10:33:40.000-04:00
diff --git a/packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts b/packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
@@ -60,6 +60,11 @@ export class TargetProjectLocator {
       }
     }
 
+    if (builtInModuleSet.has(normalizedImportExpr)) {
+      this.npmResolutionCache.set(normalizedImportExpr, null);
+      return null;
+    }
+
     // try to find npm package before using expensive typescript resolution
     const npmProject = this.findNpmPackage(normalizedImportExpr);
     if (npmProject) {
@@ -79,11 +84,6 @@ export class TargetProjectLocator {
       }
     }
 
-    if (builtInModuleSet.has(normalizedImportExpr)) {
-      this.npmResolutionCache.set(normalizedImportExpr, null);
-      return null;
-    }
-
     try {
       const resolvedModule = this.resolveImportWithRequire(
         normalizedImportExpr,

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,11 @@ export class TargetProjectLocator {`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`
	`63`	`+ if (builtInModuleSet.has(normalizedImportExpr)) {`
	`64`	`+ this.npmResolutionCache.set(normalizedImportExpr, null);`
	`65`	`+ return null;`
	`66`	`+ }`
	`67`	`+`
`63`	`68`	`// try to find npm package before using expensive typescript resolution`
`64`	`69`	`const npmProject = this.findNpmPackage(normalizedImportExpr);`
`65`	`70`	`if (npmProject) {`
`@@ -79,11 +84,6 @@ export class TargetProjectLocator {`
`79`	`84`	`}`
`80`	`85`	`}`
`81`	`86`
`82`		`- if (builtInModuleSet.has(normalizedImportExpr)) {`
`83`		`- this.npmResolutionCache.set(normalizedImportExpr, null);`
`84`		`- return null;`
`85`		`- }`
`86`		`-`
`87`	`87`	`try {`
`88`	`88`	`const resolvedModule = this.resolveImportWithRequire(`
`89`	`89`	`normalizedImportExpr,`