fix(core): do not hardcode checks for npm (#14827)

Cammisuli · web-flow · commit 3bb624a9bb13 · 2023-02-06T14:16:18.000-05:00
diff --git a/packages/nx/src/utils/project-graph-utils.spec.ts b/packages/nx/src/utils/project-graph-utils.spec.ts
@@ -54,6 +54,9 @@ describe('project graph utils', () => {
           data: {},
         },
       },
+      externalNodes: {
+        'npm:chalk': {},
+      },
       dependencies: {
         'demo-app': [
           {
diff --git a/packages/nx/src/utils/project-graph-utils.ts b/packages/nx/src/utils/project-graph-utils.ts
@@ -111,8 +111,8 @@ function collectDependentProjectNodesNames(
   for (const dependency of dependencies) {
     const dependencyName = dependency.target;
 
-    // we're only intersted in project dependencies, not npm
-    if (dependencyName.startsWith('npm:')) {
+    // we're only interested in internal nodes, not external
+    if (nxDeps.externalNodes?.[dependencyName]) {
       continue;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,8 @@ function collectDependentProjectNodesNames(`
`111`	`111`	`for (const dependency of dependencies) {`
`112`	`112`	`const dependencyName = dependency.target;`
`113`	`113`
`114`		`- // we're only intersted in project dependencies, not npm`
`115`		`- if (dependencyName.startsWith('npm:')) {`
	`114`	`+ // we're only interested in internal nodes, not external`
	`115`	`+ if (nxDeps.externalNodes?.[dependencyName]) {`
`116`	`116`	`continue;`
`117`	`117`	`}`
`118`	`118`