fix(core): use Date.now() everywhere for tasks start and end times to avoid negative durations (#18595)

AgentEnder · web-flow · commit 98a747792267 · 2023-08-15T17:54:44.000-04:00
diff --git a/packages/nx/src/tasks-runner/life-cycles/task-profiling-life-cycle.ts b/packages/nx/src/tasks-runner/life-cycles/task-profiling-life-cycle.ts
@@ -27,7 +27,7 @@ export class TaskProfilingLifeCycle implements LifeCycle {
     }
     for (let t of tasks) {
       this.timings[t.id] = {
-        perfStart: performance.now(),
+        perfStart: Date.now(),
       };
     }
   }
@@ -43,7 +43,7 @@ export class TaskProfilingLifeCycle implements LifeCycle {
       if (tr.task.endTime) {
         this.timings[tr.task.id].perfEnd = tr.task.endTime;
       } else {
-        this.timings[tr.task.id].perfEnd = performance.now();
+        this.timings[tr.task.id].perfEnd = Date.now();
       }
     }
     this.recordTaskCompletions(taskResults, metadata);

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export class TaskProfilingLifeCycle implements LifeCycle {`
`27`	`27`	`}`
`28`	`28`	`for (let t of tasks) {`
`29`	`29`	`this.timings[t.id] = {`
`30`		`- perfStart: performance.now(),`
	`30`	`+ perfStart: Date.now(),`
`31`	`31`	`};`
`32`	`32`	`}`
`33`	`33`	`}`
`@@ -43,7 +43,7 @@ export class TaskProfilingLifeCycle implements LifeCycle {`
`43`	`43`	`if (tr.task.endTime) {`
`44`	`44`	`this.timings[tr.task.id].perfEnd = tr.task.endTime;`
`45`	`45`	`} else {`
`46`		`- this.timings[tr.task.id].perfEnd = performance.now();`
	`46`	`+ this.timings[tr.task.id].perfEnd = Date.now();`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`	`this.recordTaskCompletions(taskResults, metadata);`