Skip to content

Commit ae773d5

Browse files
authored
fix(linter): skip verifying deps of deps by default in package.json (#18058)
1 parent da2674d commit ae773d5

File tree

6 files changed

+739
-133
lines changed

6 files changed

+739
-133
lines changed

e2e/linter/src/linter.test.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,12 @@ describe('Linter', () => {
452452
];
453453
return json;
454454
});
455+
// Set this to false for now until the `@nx/js:lib` generator is updated to include ts/swc helpers by default.
456+
// TODO(jack): Remove this once the above is addressed in another PR.
457+
updateJson(`libs/${mylib}/tsconfig.lib.json`, (json) => {
458+
json.compilerOptions.importHelpers = false;
459+
return json;
460+
});
455461
updateJson(`libs/${mylib}/project.json`, (json) => {
456462
json.targets.lint.options.lintFilePatterns = [
457463
`libs/${mylib}/**/*.ts`,
@@ -465,8 +471,7 @@ describe('Linter', () => {
465471
it('should report dependency check issues', () => {
466472
const rootPackageJson = readJson('package.json');
467473
const nxVersion = rootPackageJson.devDependencies.nx;
468-
const swcCoreVersion = rootPackageJson.devDependencies['@swc/core'];
469-
const swcHelpersVersion = rootPackageJson.dependencies['@swc/helpers'];
474+
const tslibVersion = rootPackageJson.devDependencies['tslib'];
470475

471476
let out = runCLI(`lint ${mylib}`, { silenceError: true });
472477
expect(out).toContain('All files pass linting');
@@ -495,9 +500,6 @@ describe('Linter', () => {
495500
{
496501
"dependencies": {
497502
"@nx/devkit": "${nxVersion}",
498-
"@swc/core": "${swcCoreVersion}",
499-
"@swc/helpers": "${swcHelpersVersion}",
500-
"nx": "${nxVersion}",
501503
},
502504
"name": "@proj/${mylib}",
503505
"type": "commonjs",

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy