Skip to content

Commit b3a0c0e

Browse files
authored
fix(misc): fix normalizing e2e project name and root (#18757)
1 parent 1440f5c commit b3a0c0e

File tree

3 files changed

+6
-42
lines changed

3 files changed

+6
-42
lines changed

packages/angular/src/generators/application/lib/normalize-options.ts

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,8 @@ export async function normalizeOptions(
2626
options.rootProject = appProjectRoot === '.';
2727
options.projectNameAndRootFormat = projectNameAndRootFormat;
2828

29-
let e2eProjectName = 'e2e';
30-
let e2eProjectRoot = 'e2e';
31-
if (!options.rootProject) {
32-
const projectNameAndRoot = await determineProjectNameAndRootOptions(host, {
33-
name: `${options.name}-e2e`,
34-
projectType: 'application',
35-
directory: options.directory,
36-
projectNameAndRootFormat: options.projectNameAndRootFormat,
37-
rootProject: options.rootProject,
38-
callingGenerator: '@nx/angular:application',
39-
});
40-
e2eProjectName = projectNameAndRoot.projectName;
41-
e2eProjectRoot = projectNameAndRoot.projectRoot;
42-
}
29+
const e2eProjectName = options.rootProject ? 'e2e' : `${appProjectName}-e2e`;
30+
const e2eProjectRoot = options.rootProject ? 'e2e' : `${appProjectRoot}-e2e`;
4331

4432
const parsedTags = options.tags
4533
? options.tags.split(',').map((s) => s.trim())

packages/next/src/generators/application/lib/normalize-options.ts

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,8 @@ export async function normalizeOptions(
3535
options.rootProject = appProjectRoot === '.';
3636
options.projectNameAndRootFormat = projectNameAndRootFormat;
3737

38-
let e2eProjectName = 'e2e';
39-
let e2eProjectRoot = 'e2e';
40-
if (!options.rootProject) {
41-
const projectNameAndRoot = await determineProjectNameAndRootOptions(host, {
42-
name: `${options.name}-e2e`,
43-
projectType: 'application',
44-
directory: options.directory,
45-
projectNameAndRootFormat: options.projectNameAndRootFormat,
46-
rootProject: options.rootProject,
47-
callingGenerator: '@nx/next:application',
48-
});
49-
e2eProjectName = projectNameAndRoot.projectName;
50-
e2eProjectRoot = projectNameAndRoot.projectRoot;
51-
}
38+
const e2eProjectName = options.rootProject ? 'e2e' : `${appProjectName}-e2e`;
39+
const e2eProjectRoot = options.rootProject ? 'e2e' : `${appProjectRoot}-e2e`;
5240

5341
const name = names(options.name).fileName;
5442

packages/react/src/generators/application/lib/normalize-options.ts

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,8 @@ export async function normalizeOptions<T extends Schema = Schema>(
3636
options.rootProject = appProjectRoot === '.';
3737
options.projectNameAndRootFormat = projectNameAndRootFormat;
3838

39-
let e2eProjectName = 'e2e';
40-
let e2eProjectRoot = 'e2e';
41-
if (!options.rootProject) {
42-
const projectNameAndRoot = await determineProjectNameAndRootOptions(host, {
43-
name: `${options.name}-e2e`,
44-
projectType: 'application',
45-
directory: options.directory,
46-
projectNameAndRootFormat: options.projectNameAndRootFormat,
47-
rootProject: options.rootProject,
48-
callingGenerator,
49-
});
50-
e2eProjectName = projectNameAndRoot.projectName;
51-
e2eProjectRoot = projectNameAndRoot.projectRoot;
52-
}
39+
const e2eProjectName = options.rootProject ? 'e2e' : `${appProjectName}-e2e`;
40+
const e2eProjectRoot = options.rootProject ? 'e2e' : `${appProjectRoot}-e2e`;
5341

5442
const parsedTags = options.tags
5543
? options.tags.split(',').map((s) => s.trim())

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy