fix(core): skip peer deps from devDependencies on createPackageJson (#14958)

meeroslav · FrozenPandaz · commit c21e9fb18e33 · 2023-02-15T11:09:32.000-05:00
(cherry picked from commit b583f89)
diff --git a/packages/nx/src/utils/create-package-json.ts b/packages/nx/src/utils/create-package-json.ts
@@ -72,8 +72,13 @@ export function createPackageJson(
       const isOptionalPeer =
         npmDeps.peerDependenciesMeta[packageName]?.optional;
       if (!isOptionalPeer) {
-        packageJson.peerDependencies ??= {};
-        packageJson.peerDependencies[packageName] = version;
+        if (
+          !options.isProduction ||
+          rootPackageJson.dependencies?.[packageName]
+        ) {
+          packageJson.peerDependencies ??= {};
+          packageJson.peerDependencies[packageName] = version;
+        }
       } else if (!options.isProduction) {
         // add peer optional dependencies if not in production
         packageJson.peerDependencies ??= {};
@@ -184,16 +189,3 @@ function recursivelyCollectPeerDependencies(
     return list;
   }
 }
-
-function filterOptionalPeerDependencies(
-  packageJson: PackageJson
-): Record<string, string> {
-  let peerDependencies;
-  Object.keys(packageJson.peerDependencies).forEach((key) => {
-    if (!packageJson.peerDependenciesMeta?.[key]?.optional) {
-      peerDependencies = peerDependencies || {};
-      peerDependencies[key] = packageJson.peerDependencies[key];
-    }
-  });
-  return peerDependencies;
-}
