fix(js): update babel preset to specify minor version of core-js for better optimization #22433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e43e541. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
previously approved these changes
Mar 21, 2024
Coly010
approved these changes
Mar 21, 2024
ndcunningham
approved these changes
Mar 21, 2024
6b7f9d5 to
4a72fa2
Compare
…better optimization - Also fix rollup:configuration generator to add core-js as needed
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the minor version when passing
corejsoption to@babel/preset-env. When it is passed as just major version3, there are some optimizations that may be skipped.@nx/rollup:configurationgenerator to addcore-jsas needed (apps don't need it anymore, but libs still do if they targetcjs)core-jsto^3.36.1Current Behavior
Expected Behavior
Related Issue(s)
Fixes #21354