fix(es/utils): Skip var declarator name in RefRewriter (#8125)

magic-akari · web-flow · commit fb81a36adceb · 2023-10-15T10:24:40.000Z
**Related issue:** - Closes #8124
diff --git a/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/input.ts b/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/input.ts
@@ -0,0 +1,9 @@
+namespace Foo {
+    export var a = 1;
+    for (var a; a < 5; a++) {}
+}
+
+namespace Bar {
+    export var b = 2;
+    var b = 3;
+}
diff --git a/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/output.js b/crates/swc_ecma_transforms_typescript/tests/fixture/issue-8124/output.js
@@ -0,0 +1,10 @@
+var Foo;
+(function(Foo) {
+    Foo.a = 1;
+    for(var a; Foo.a < 5; Foo.a++){}
+})(Foo || (Foo = {}));
+var Bar;
+(function(Bar) {
+    Bar.b = 2;
+    var b = 3;
+})(Bar || (Bar = {}));
diff --git a/crates/swc_ecma_utils/src/lib.rs b/crates/swc_ecma_utils/src/lib.rs
@@ -3062,6 +3062,11 @@ where
         }
     }
 
+    fn visit_mut_var_declarator(&mut self, n: &mut VarDeclarator) {
+        // skip var declarator name
+        n.init.visit_mut_with(self);
+    }
+
     fn visit_mut_pat(&mut self, n: &mut Pat) {
         match n {
             Pat::Ident(BindingIdent { id, .. }) => {

Original file line number	Diff line number	Diff line change
`@@ -3062,6 +3062,11 @@ where`
`3062`	`3062`	`}`
`3063`	`3063`	`}`
`3064`	`3064`
	`3065`	`+ fn visit_mut_var_declarator(&mut self, n: &mut VarDeclarator) {`
	`3066`	`+ // skip var declarator name`
	`3067`	`+ n.init.visit_mut_with(self);`
	`3068`	`+ }`
	`3069`	`+`
`3065`	`3070`	`fn visit_mut_pat(&mut self, n: &mut Pat) {`
`3066`	`3071`	`match n {`
`3067`	`3072`	`Pat::Ident(BindingIdent { id, .. }) => {`