fix: nextTick mocking error message to mention correct config option (#4215)

AriPerkkio · web-flow · commit 98fe3d554093 · 2023-10-02T16:45:53.000+02:00
diff --git a/docs/api/vi.md b/docs/api/vi.md
@@ -698,7 +698,7 @@ unmockedIncrement(30) === 31
 
   To enable mocking timers, you need to call this method. It will wrap all further calls to timers (such as `setTimeout`, `setInterval`, `clearTimeout`, `clearInterval`, `nextTick`, `setImmediate`, `clearImmediate`, and `Date`), until [`vi.useRealTimers()`](#vi-userealtimers) is called.
 
-  Mocking `nextTick` is not supported when running Vitest inside `node:child_process` by using `--no-threads`. NodeJS uses `process.nextTick` internally in `node:child_process` and hangs when it is mocked. Mocking `nextTick` is supported when running Vitest with `--threads`.
+  Mocking `nextTick` is not supported when running Vitest inside `node:child_process` by using `--pool=forks`. NodeJS uses `process.nextTick` internally in `node:child_process` and hangs when it is mocked. Mocking `nextTick` is supported when running Vitest with `--pool=threads`.
 
   The implementation is based internally on [`@sinonjs/fake-timers`](https://github.com/sinonjs/fake-timers).
 
diff --git a/packages/vitest/src/integrations/vi.ts b/packages/vitest/src/integrations/vi.ts
@@ -211,7 +211,7 @@ function createVitest(): VitestUtils {
       if (workerState.isChildProcess) {
         if (config?.toFake?.includes('nextTick') || workerState.config?.fakeTimers?.toFake?.includes('nextTick')) {
           throw new Error(
-            'vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in node:child_process. Use --threads if mocking nextTick is required.',
+            'vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in node:child_process. Use --pool=threads if mocking nextTick is required.',
           )
         }
       }
diff --git a/test/config/test/failures.test.ts b/test/config/test/failures.test.ts
@@ -95,7 +95,7 @@ test('nextTick cannot be mocked inside child_process', async () => {
     include: ['./fixtures/test/fake-timers.test.ts'],
   })
 
-  expect(stderr).toMatch('Error: vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in node:child_process. Use --threads if mocking nextTick is required.')
+  expect(stderr).toMatch('Error: vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in node:child_process. Use --pool=threads if mocking nextTick is required.')
 })
 
 test('nextTick can be mocked inside worker_threads', async () => {

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ function createVitest(): VitestUtils {`
`211`	`211`	`if (workerState.isChildProcess) {`
`212`	`212`	`if (config?.toFake?.includes('nextTick') \|\| workerState.config?.fakeTimers?.toFake?.includes('nextTick')) {`
`213`	`213`	`throw new Error(`
`214`		`- 'vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in node:child_process. Use --threads if mocking nextTick is required.',`
	`214`	`+ 'vi.useFakeTimers({ toFake: ["nextTick"] }) is not supported in node:child_process. Use --pool=threads if mocking nextTick is required.',`
`215`	`215`	`)`
`216`	`216`	`}`
`217`	`217`	`}`