feat(benchmark): move importTinybench to runner (#4376)

Dunqing · web-flow · commit c36d2b97e4ba · 2023-10-27T11:34:39.000+02:00
diff --git a/packages/vitest/package.json b/packages/vitest/package.json
@@ -172,7 +172,6 @@
     "birpc": "0.2.14",
     "chai-subset": "^1.6.0",
     "cli-truncate": "^3.1.0",
-    "event-target-polyfill": "^0.0.3",
     "execa": "^7.1.1",
     "expect-type": "^0.16.0",
     "fast-glob": "^3.3.0",
diff --git a/packages/vitest/src/runtime/runners/benchmark.ts b/packages/vitest/src/runtime/runners/benchmark.ts
@@ -8,13 +8,6 @@ import type { BenchTask, Benchmark, BenchmarkResult } from '../../types/benchmar
 import type { ResolvedConfig } from '../../types/config'
 import type { VitestExecutor } from '../execute'
 
-async function importTinybench() {
-  if (!globalThis.EventTarget)
-    await import('event-target-polyfill' as any)
-
-  return (await import('tinybench'))
-}
-
 function createBenchmarkResult(name: string): BenchmarkResult {
   return {
     name,
@@ -26,8 +19,9 @@ function createBenchmarkResult(name: string): BenchmarkResult {
 
 const benchmarkTasks = new WeakMap<Benchmark, import('tinybench').Task>()
 
-async function runBenchmarkSuite(suite: Suite, runner: VitestRunner) {
-  const { Task, Bench } = await importTinybench()
+async function runBenchmarkSuite(suite: Suite, runner: NodeBenchmarkRunner) {
+  const { Task, Bench } = await runner.importTinybench()
+
   const start = performance.now()
 
   const benchmarkGroup: Benchmark[] = []
@@ -132,6 +126,10 @@ export class NodeBenchmarkRunner implements VitestRunner {
 
   constructor(public config: ResolvedConfig) {}
 
+  async importTinybench() {
+    return await import('tinybench')
+  }
+
   importFile(filepath: string, source: VitestRunnerImportSource): unknown {
     if (source === 'setup')
       getWorkerState().moduleCache.delete(filepath)
diff --git a/packages/vitest/src/types/config.ts b/packages/vitest/src/types/config.ts
@@ -736,10 +736,7 @@ export interface ResolvedConfig extends Omit<Required<UserConfig>, 'config' | 'f
 
   api?: ApiConfig
 
-  benchmark?: Required<Omit<BenchmarkUserOptions, 'outputFile'>> & {
-    outputFile?: BenchmarkUserOptions['outputFile']
-  }
-
+  benchmark?: Required<Omit<BenchmarkUserOptions, 'outputFile'>> & Pick<BenchmarkUserOptions, 'outputFile'>
   shard?: {
     index: number
     count: number
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
