fix(useVModel): clone set to true triggered infinite loop (#3097)

motian · antfu · web-flow · commit 48f4c6e1dd6c · 2023-08-08T16:38:09.000Z
Co-authored-by: Anthony Fu &lt;anthonyfu117@hotmail.com&gt;
diff --git a/packages/core/useVModel/index.ts b/packages/core/useVModel/index.ts
@@ -1,6 +1,6 @@
 import { isDef } from '@vueuse/shared'
 import type { Ref, UnwrapRef, WritableComputedRef } from 'vue-demi'
-import { computed, getCurrentInstance, isVue2, ref, watch } from 'vue-demi'
+import { computed, getCurrentInstance, isVue2, nextTick, ref, watch } from 'vue-demi'
 import type { CloneFn } from '../useCloned'
 import { cloneFnJSON } from '../useCloned'
 
@@ -127,16 +127,23 @@ export function useVModel<P extends object, K extends keyof P, Name extends stri
   if (passive) {
     const initialValue = getValue()
     const proxy = ref<P[K]>(initialValue!)
+    let isUpdating = false
 
     watch(
       () => props[key!],
-      v => (proxy as any).value = cloneFn(v) as UnwrapRef<P[K]>,
+      (v) => {
+        if (!isUpdating) {
+          isUpdating = true
+          ;(proxy as any).value = cloneFn(v) as UnwrapRef<P[K]>
+          nextTick(() => isUpdating = false)
+        }
+      },
     )
 
     watch(
       proxy,
       (v) => {
-        if (v !== props[key!] || deep)
+        if (!isUpdating && (v !== props[key!] || deep))
           triggerEmit(v as P[K])
       },
       { deep },
