-
Notifications
You must be signed in to change notification settings - Fork 32
Fix EGL Window creation and prevent GLFW-Wayland from SEGFAULTING #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…n DFLY. Patch applicable to Mesa 18+. This patch file was diffed from Mesa 20.2.0-devel (git-412e29c277)
…cky solution to place a pointer in place of the version number. The branch that uses mincore to do so fails on DFLY. The other branch works and is thus forced. Patch applicable to Mesa 18+. This patch file was diffed from Mesa 20.2.0-devel (git-412e29c277)
…n DFLY. Forcefully prevent branch leading to wl_dmabuf to be false. Patch applicable to Mesa 18+. This patch file was diffed from Mesa 20.2.0-devel (git-412e29c277)
@FrostKiwi sorry for not taking care of this PR earlier, but would you still have a working DragonFly setup running wayland/Sway ? |
Sure. I actually switched to FreeBSD, but I'll throw DragonFlyBSD again on a machine an check the state of Window creation. |
If you could actually describe the steps maybe we can do it ourselves. Let me know :) |
Ohh sry. Kind of stuck with other tasks to reinstall a whole OS to fix something that might not be there anymore. The crux of the issue was Wayland window creation segfaulting under specific situations, because DragonFlyBSD did not support Unless I misremember something, to confirm this still being an issue would be to create a Window using GLFW in Wayland mode under swaywm as the compositor. GLFW usually comes default in X11 mode and has to be recompiled with |
These are fixes that I needed to apply in order for glfwCreateWindow() to stop SEGFAULTING, with the main culprit being EXT_image_dma_buf usage, despite not being supported.
The patches allow window creation on sway, with Mesa 18.3.2 and newer. However, due to EXT_KHR not being properly used, the window remains blank with Mesa 18.3.2, even though a context is successfully created. Proper EXT_KHR extension use was fixed at some point and with Mesa 20.2.0-devel (git-412e29c277) at the latest, window and context creation works without issue.
All patch files were diffed against Mesa 20.2.0-devel (git-412e29c277).