suggestion for prefer-nullish-coalescing PR #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kirkwaiblinger
force-pushed
the
pnc-suggestion
branch
from
15f616e to
2defdf4
Compare
OlivierZal
approved these changes
Jan 21, 2025
OlivierZal
merged commit dce2427
into
OlivierZal:prefer-nullish-coalescing-10470
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for typescript-eslint#10517
The main thing this suggestion does is to remove the
isIdentifierOrMemberExpressionType()workaround from theisConditionalTest()andisBooleanContext()functions, and move the logic to distinguish between ternary's test and the ternary overall earlier in the call stack (by taking it as a parameter toisTruthinessCheckEligibleForPreferNullish()/isEligibleForPreferNullish())Otherwise it's just a bit of renaming, inverting the sign and naming of a few things, and adding some jsdoc since this is complicated stuff.
Feel free to merge/cherry-pick this diff to your PR branch 🙂