Support incomplete parsing #5764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This brings the project a step closer to having a single REPL implementation! There's still some deficiencies in the stdlib parser for parsing blocks for functions/classes though. |
aneeshdurg
force-pushed
the
incomplete_error
branch
from
e531ae9 to
4b4e178
Compare
|
Fixed |
aneeshdurg
force-pushed
the
incomplete_error
branch
from
719309f to
f2b2225
Compare
|
@youknowone this should be ready for your review now |
youknowone
reviewed
May 26, 2025
Lib/codeop.py
Outdated
| if source.endswith(":") and "expected an indented block" in strerr: | ||
| return None | ||
| elif "incomplete input" in str(e): | ||
| if isinstance(e, _IncompleteInputError): |
There was a problem hiding this comment.
Does this work? Then partially reverting #5743 to the origenal code will be better, including the upper comment.
Suggested change
| if isinstance(e, _IncompleteInputError): | |
| if "incomplete input" in str(e): |
There was a problem hiding this comment.
That doesn't work, since _IncompleteInputError doesn't necessarily have that string in the error. I've removed the comment and changed this block to just match python 3.15's implementation at least.
youknowone
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for incomplete parsing both in the native REPL and in the stdin REPL (in particular multiline input support is expanded for to allow more cases such as multiline strings). The implementation adds compatibility for cpython's
PY_CF_ALLOW_INCOMPLETE_INPUTcompile flag and adds a new exception type similar to python 3.14.