IGNITE-25359 BinaryStreams moved to ignite-binary-impl #12188
Conversation
| import java.nio.ByteBuffer; | ||
|
|
||
| /** | ||
| * Utility class to provide static methods to create {@link BinaryInputStream} or {@link BinaryOutputStream} in different modes. |
There was a problem hiding this comment.
Javadoc is incorrect, it is not a utility class with a bunch of static methods but an interface suitable for loading via ServiceLoader mechanism.
| static { | ||
| Iterator<BinaryStreamsFactory> factories = CommonUtils.loadService(BinaryStreamsFactory.class).iterator(); | ||
|
|
||
| A.ensure(factories.hasNext(), "BinaryStreamsFactory implementation not found. Please, add ignite-binary-impl to classpath"); |
There was a problem hiding this comment.
I suggest to be more specific in this error message and give a hint that we tried and failed to load a service from classpath.
How about Implementation for BinaryStreamsFactory service not found. Please add ignite-binary-impl to classpath.
|
I suggest to add a README.txt/README.md file to ignite-binary-impl module with a short description of what this module is about and how it is supposed to use it. Module's name is very general and doesn't provide a lot of information though the module is rather important for developers in the community. |
|
@sergey-chugunov-1985 README.txt for both ignite-binary-api, ignite-binary-impl added. |
|
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.