-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(b-calendar/b-form-datepicker): add day, month, and year type options (closes #6034) #6801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…nth and year calendar types and tests for keyboard navigation of all types
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/FEnq7X5CBhPVavpULYnVrizK9mzW |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a477e8:
|
@Hiws or @jacobmllr95 any idea why Codacy results are conflicting with what the |
this would be exactly what i was looking for. looks great and seems to work just fine. how long does it usually take for something like this to go live in bootstrap vue? sry im new to vue, bootstrap and github. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Describe the PR
This pull request adds types to the
b-calendar
andb-form-datepicker
components to support for multiple types of date-related picking inputs. The types includedate
(default, and the current date picker),day
(days of the week),month
(months of the year), andyear
(years in a decade). I chose to have the components to keep the value formatting the same no matter what type is selected for consistency. Each instance can then utilize the date as needed and ignore the day, month, or year that aren't relevant for them.I am working on a project where the month and year picker options will be needed in the near future, so I figured I'd add them for anyone else needing these options. Since the only issue that was open and seemed related didn't appear to be being worked on, I figured I'd jump in and get it done. Our development team has gone all-in on using BootstrapVue and we're wanting to avoid having another dependency just for a month and year picker.
I included days of the week since I was trying to generalize it for multiple use cases and am open to feedback. Tests have been added to cover these new types for both components. The documentation has been updated to include new props and updated wording for existing props that are related to types. Examples have been added for the
b-calendar
andb-form-datepicker
README.md
files for the documentation site to show users what the different type option experiences are like.What it looks like
Docs
b-calendar
b-form-datepicker
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: