docs: replace source_secret with secret #2731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elf-hosted and cloud
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation and examples to replace the legacy source_secret parameter with the new secret parameter, aligning with the Cloud API’s current query parameter.
- Renames all occurrences of
source_secrettosecretin CURL examples and TypeScript snippets - Updates descriptive text to reflect the new
secretparameter usage
Comments suppressed due to low confidence (2)
website/product/cloud.md:90
- [nitpick] The environment variable
SECRETis very generic and could collide with other secrets. Consider renaming it to something more specific likeELECTRIC_SECRETorCLOUD_SECRETfor clarity.
&secret=$SECRET"
website/product/cloud.md:139
- [nitpick] Mixing backticks for static string literals can be confusing; consider using single or double quotes (
'secret'or"secret") for consistency with the rest of the codebase.
origenUrl.searchParams.set(`secret`, process.env.SECRET)
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our Cloud accepts the query param
secret, we should just remove mentions to the legacysource_secretin our docs. See #2729 for context.